Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2811303003:
arc: Add unit tests for ArcKioskBridge (Closed)
|
Created:
3 years, 8 months ago by Sergey Poromov Modified:
3 years, 8 months ago CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, poromov+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, ios-reviews_chromium.org, Daniel Erat Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Descriptionarc: Add unit tests for ArcKioskBridge
BUG=710896
TEST=Run components_unittests
Review-Url: https://codereview.chromium.org/2811303003
Cr-Commit-Position: refs/heads/master@{#464379}
Committed: https://chromium.googlesource.com/chromium/src/+/d6c28d8578596288b8ca30f051048b6f5ce03934
Patch Set 1 #
Total comments: 8
Patch Set 2 : fix comments #
Messages
Total messages: 17 (12 generated)
The CQ bit was checked by poromov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
poromov@chromium.org changed reviewers: + lhchavez@chromium.org
+derat FYI :) thanks for doing this! lgtm. https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... File components/arc/kiosk/arc_kiosk_bridge_unittest.cc (right): https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... components/arc/kiosk/arc_kiosk_bridge_unittest.cc:18: MockArcKioskBridgeDelegate() {} nit: = default https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... components/arc/kiosk/arc_kiosk_bridge_unittest.cc:30: ArcKioskBridgeTest() {} nit: = default
derat@chromium.org changed reviewers: + derat@chromium.org
lgtm with a few suggestions https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... File components/arc/kiosk/arc_kiosk_bridge_unittest.cc (right): https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... components/arc/kiosk/arc_kiosk_bridge_unittest.cc:33: bridge_service_ = base::MakeUnique<ArcBridgeService>(); consider putting initialization in the c'tor instead whenever possible (i.e. when you're not relying on work done in the base class's SetUp method): https://github.com/google/googletest/blob/master/googletest/docs/FAQ.md#shoul... https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... components/arc/kiosk/arc_kiosk_bridge_unittest.cc:44: std::unique_ptr<ArcBridgeService> bridge_service_; consider moving these members into the 'protected' section so tests can access them directly without needing to define accessors
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by poromov@chromium.org to run a CQ dry run
The CQ bit was checked by poromov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lhchavez@chromium.org, derat@chromium.org Link to the patchset: https://codereview.chromium.org/2811303003/#ps20001 (title: "fix comments")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... File components/arc/kiosk/arc_kiosk_bridge_unittest.cc (right): https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... components/arc/kiosk/arc_kiosk_bridge_unittest.cc:18: MockArcKioskBridgeDelegate() {} On 2017/04/12 18:24:41, Luis Héctor Chávez wrote: > nit: = default Done. https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... components/arc/kiosk/arc_kiosk_bridge_unittest.cc:30: ArcKioskBridgeTest() {} On 2017/04/12 18:24:41, Luis Héctor Chávez wrote: > nit: = default Done. https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... components/arc/kiosk/arc_kiosk_bridge_unittest.cc:33: bridge_service_ = base::MakeUnique<ArcBridgeService>(); On 2017/04/12 18:29:31, Daniel Erat wrote: > consider putting initialization in the c'tor instead whenever possible (i.e. > when you're not relying on work done in the base class's SetUp method): > https://github.com/google/googletest/blob/master/googletest/docs/FAQ.md#shoul... Done. https://codereview.chromium.org/2811303003/diff/1/components/arc/kiosk/arc_ki... components/arc/kiosk/arc_kiosk_bridge_unittest.cc:44: std::unique_ptr<ArcBridgeService> bridge_service_; On 2017/04/12 18:29:31, Daniel Erat wrote: > consider moving these members into the 'protected' section so tests can access > them directly without needing to define accessors Done.
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492081364911360,
"parent_rev": "a5d70ebb214f8d77c943c98f1e2908c91b3d62b7", "commit_rev":
"d6c28d8578596288b8ca30f051048b6f5ce03934"}
Message was sent while issue was closed.
Description was changed from ========== arc: Add unit tests for ArcKioskBridge BUG=710896 TEST=Run components_unittests ========== to ========== arc: Add unit tests for ArcKioskBridge BUG=710896 TEST=Run components_unittests Review-Url: https://codereview.chromium.org/2811303003 Cr-Commit-Position: refs/heads/master@{#464379} Committed: https://chromium.googlesource.com/chromium/src/+/d6c28d8578596288b8ca30f05104... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d6c28d8578596288b8ca30f05104... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
