Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2811293003: [Chromecast] Initialize media_resource_tracker with media_thread. (Closed)

Created:
3 years, 8 months ago by Simeon
Modified:
3 years, 8 months ago
Reviewers:
halliwell
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Initialize media_resource_tracker with media_thread. There was a race condition with the lazy initialization logic from before, where the media_resource_tracker() lazy-getter could be called by something on the media thread before the call to media_resource_tracker()->InitializeMediaLib() in cast_browser_main_parts. This would make the media resource tracker think that the media thread was the UI thread, which would cause the InitializeMediaLib() call to fail, thinking it was on the wrong thread. BUG=NONE TEST=build cast_shell_apk with gn arg is_cast_audio_only=true, install on Android emulator and verify that crash does not happen on browser process startup. Review-Url: https://codereview.chromium.org/2811293003 Cr-Commit-Position: refs/heads/master@{#464297} Committed: https://chromium.googlesource.com/chromium/src/+/ebc15025d19fb3a0be141495f36f36b5cd73673e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Simeon
This fixes the crash that thoren@ and I were seeing yesterday on Android emulators.
3 years, 8 months ago (2017-04-12 23:48:47 UTC) #2
halliwell
On 2017/04/12 23:48:47, Simeon wrote: > This fixes the crash that thoren@ and I were ...
3 years, 8 months ago (2017-04-13 00:49:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811293003/1
3 years, 8 months ago (2017-04-13 04:09:38 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 04:44:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebc15025d19fb3a0be141495f36f...

Powered by Google App Engine
This is Rietveld 408576698