Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 2811273004: [DevTools] Account for host device pixel ratio in Device Mode screenshots (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Account for host device pixel ratio in Device Mode screenshots BUG=638281 Review-Url: https://codereview.chromium.org/2811273004 Cr-Commit-Position: refs/heads/master@{#464239} Committed: https://chromium.googlesource.com/chromium/src/+/a95ba76f368fba30b23363b7692cae2da92cb062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Take a look please.
3 years, 8 months ago (2017-04-12 22:35:33 UTC) #3
pfeldman
lgtm
3 years, 8 months ago (2017-04-13 00:29:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811273004/1
3 years, 8 months ago (2017-04-13 00:45:01 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 01:54:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a95ba76f368fba30b23363b7692c...

Powered by Google App Engine
This is Rietveld 408576698