Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2811213002: Move ScriptState::GetExecutionContext (Part 6) (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, kinuko+watch, kinuko+fileapi, mlamouri+watch-blink_chromium.org, nhiroki, tommyw+watchlist_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScriptState::GetExecutionContext (Part 6) This CL removes ScriptState::GetExecutionContext and replaces all remaining calls to the function with ExecutionContext::From. BUG=682322 Review-Url: https://codereview.chromium.org/2811213002 Cr-Commit-Position: refs/heads/master@{#464162} Committed: https://chromium.googlesource.com/chromium/src/+/507756d8e487854f780f5ee37962231491cee852

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 14 (7 generated)
adithyas
3 years, 8 months ago (2017-04-11 21:47:20 UTC) #2
jbroman
lgtm
3 years, 8 months ago (2017-04-11 21:48:07 UTC) #3
haraken
LGTM
3 years, 8 months ago (2017-04-11 23:03:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811213002/20001
3 years, 8 months ago (2017-04-12 17:17:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/428264)
3 years, 8 months ago (2017-04-12 19:25:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811213002/20001
3 years, 8 months ago (2017-04-12 21:07:17 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 21:52:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/507756d8e487854f780f5ee37962...

Powered by Google App Engine
This is Rietveld 408576698