Reintroduce OffscreenCanvasSurfaceClient interface.

Reintroduce OffscreenCanvasSurfaceClient interface.

This interface got switched out for DisplayCompositorClient, which
became FrameSinkManagerClient, in http://crrev.com/2695603002.

The two interfaces were very similar, both having just
OnSurfaceCreated() but with different intentions. FrameSinkManagerClient
is intended for the single GPU to browser connection.
OffscreenCanvasSurfaceClient is intended for multiple browser to
renderer connections. This reintroduces OffscreenCanvasSurfaceClient for
clarity.

BUG=664547
Review-Url: https://codereview.chromium.org/2811193003
Cr-Commit-Position: refs/heads/master@{#466735}
Committed: https://chromium.googlesource.com/chromium/src/+/88bb958c59b218a5fe595ffe3ace9f11f21e28db

[kylechar, 2017-04-18 18:32:50]

Description was changed from

==========
Reintroduce OffscreenCanvasSurfaceClient interface.

This interface got switched out for DisplayCompositorClient, which
became FrameSinkManagerClient, at some point. The interfaces had the
same method, OnSurfaceCreated() but different intentions. One was for a
single GPU to browser connection and the other for multiple browser to
renderer connections. This reintroduces OffscreenCanvasSurfaceClient for
clarity.

BUG=664547
==========

to

==========
Reintroduce OffscreenCanvasSurfaceClient interface.

This interface got switched out for DisplayCompositorClient, which
became FrameSinkManagerClient, in http://crrev.com/2695603002.

The two interfaces were very similar, both having just
OnSurfaceCreated() but with different intentions. FrameSinkManagerClient
is intended for the single GPU to browser connection.
OffscreenCanvasSurfaceClient is intended for multiple browser to
renderer connections. This reintroduces OffscreenCanvasSurfaceClient for
clarity.

BUG=664547
==========

[kylechar, 2017-04-20 21:18:08]

kylechar@chromium.org changed reviewers:
+ fsamuel@chromium.org, junov@chromium.org, tsepez@chromium.org

[kylechar, 2017-04-20 21:18:09]

fsamuel: FYI from original CL.
junov: content/browser/rendere_host/* and
third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.h
tsepez: mojom/security

[Tom Sepez, 2017-04-20 21:46:12]

lgtm

[Fady Samuel, 2017-04-21 01:19:47]

lgtm

[Fady Samuel, 2017-04-22 23:11:11]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-22 23:11:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 23:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-22 23:14:49]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kylechar, 2017-04-24 16:44:51]

Patchset #4 (id:60001) has been deleted

[kylechar, 2017-04-24 16:46:24]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 16:46:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-04-24 16:59:13]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[kylechar, 2017-04-24 16:59:13]

+sky for the content/test/BUILD.gn

[Justin Novosad, 2017-04-24 17:21:14]

webkit lgtm

[commit-bot: I haz the power, 2017-04-24 18:55:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 18:55:35]

Dry run: This issue passed the CQ dry run.

[sky, 2017-04-24 19:15:17]

LGTM

[kylechar, 2017-04-24 20:14:34]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-04-24 20:14:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2811193003/#ps80001
(title: "Add dep on mojom.")

[commit-bot: I haz the power, 2017-04-24 20:16:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 20:22:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493064874675770,
"parent_rev": "deb6be8f732a157329490e49fbfd41826757a0fd", "commit_rev":
"88bb958c59b218a5fe595ffe3ace9f11f21e28db"}

[commit-bot: I haz the power, 2017-04-24 20:23:00]

Description was changed from

==========
Reintroduce OffscreenCanvasSurfaceClient interface.

This interface got switched out for DisplayCompositorClient, which
became FrameSinkManagerClient, in http://crrev.com/2695603002.

The two interfaces were very similar, both having just
OnSurfaceCreated() but with different intentions. FrameSinkManagerClient
is intended for the single GPU to browser connection.
OffscreenCanvasSurfaceClient is intended for multiple browser to
renderer connections. This reintroduces OffscreenCanvasSurfaceClient for
clarity.

BUG=664547
==========

to

==========
Reintroduce OffscreenCanvasSurfaceClient interface.

This interface got switched out for DisplayCompositorClient, which
became FrameSinkManagerClient, in http://crrev.com/2695603002.

The two interfaces were very similar, both having just
OnSurfaceCreated() but with different intentions. FrameSinkManagerClient
is intended for the single GPU to browser connection.
OffscreenCanvasSurfaceClient is intended for multiple browser to
renderer connections. This reintroduces OffscreenCanvasSurfaceClient for
clarity.

BUG=664547

Review-Url: https://codereview.chromium.org/2811193003
Cr-Commit-Position: refs/heads/master@{#466735}
Committed:
https://chromium.googlesource.com/chromium/src/+/88bb958c59b218a5fe595ffe3ace...
==========

[commit-bot: I haz the power, 2017-04-24 20:23:01]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/88bb958c59b218a5fe595ffe3ace...