Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2811183006: Revert of Build ZIP archiver in ui/file_manager. (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
CC:
chromium-reviews, yawano
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Build ZIP archiver in ui/file_manager. (patchset #5 id:80001 of https://codereview.chromium.org/2808993003/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 464309 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc3MDY1ZDk4MTZiMzRhNWNjNzkxMzg5NGI4Yjc1NmU3YzNlNmZiNzkM Original issue's description: > Build ZIP archiver. > > This CL adds and changes some files in ui/file_manager to build ZIP archiver. > We are going to add ZIP archiver to the list of component extensions > in another CL, so ZIP archiver still won't show up in the context > menu with this patch. > > BUG=607078 > TEST=manually tested > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2808993003 > Cr-Commit-Position: refs/heads/master@{#464309} > Committed: https://chromium.googlesource.com/chromium/src/+/77065d9816b34a5cc7913894b8b756e7c3e6fb79 TBR=mtomasz@chromium.org,fukino@chromium.org,hashimoto@chromium.org,takise@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607078 Review-Url: https://codereview.chromium.org/2811183006 Cr-Commit-Position: refs/heads/master@{#464315} Committed: https://chromium.googlesource.com/chromium/src/+/fca615ce366c3d28d9a0a48522313a3710306be1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -116 lines) Patch
M ui/file_manager/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager_resources.grd View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/file_manager/zip_archiver/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/file_manager/zip_archiver/cpp/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
M ui/file_manager/zip_archiver/manifest.json View 2 chunks +9 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
findit-for-me
Created Revert of Build ZIP archiver in ui/file_manager.
3 years, 8 months ago (2017-04-13 05:45:58 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-04-13 05:45:59 UTC) #3
Yuta Kitamura
lgtm
3 years, 8 months ago (2017-04-13 05:59:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811183006/1
3 years, 8 months ago (2017-04-13 06:00:17 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 06:02:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fca615ce366c3d28d9a0a4852231...

Powered by Google App Engine
This is Rietveld 408576698