Do not use new struct type where unnecessary.

Do not use new struct type where unnecessary.

We can use TUPLE2 or TUPLE3 for structs that do not need special
handling by deoptimizer and compiler.

This frees up a few instance types, so that adding the next few
new structs will not cause ABI compatibility to break.


R=mstarzinger@chromium.org

Review-Url: https://codereview.chromium.org/2811183005
Cr-Commit-Position: refs/heads/master@{#44685}
Committed: https://chromium.googlesource.com/v8/v8/+/7b4e4ab70fcd962a3fad3710e0b07ad30d87c765

[Michael Starzinger, 2017-04-13 11:25:59]

https://codereview.chromium.org/2811183005/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode7491
src/objects.h:7491: class TypeFeedbackInfo: public Struct {
nit: Should inherit from Tuple3 now.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode7513
src/objects.h:7513: static const int kStorage2Offset = kStorage1Offset +
kPointerSize;
Likewise.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode9837
src/objects.h:9837: class CallHandlerInfo: public Struct {
nit: Should inherit from Tuple2 now.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode9845
src/objects.h:9845: static const int kDataOffset = kCallbackOffset +
kPointerSize;
Likewise.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode10091
src/objects.h:10091: static const int kBreakPointObjectsIndex =
Let's use Tuple2::kValue1Offset and Tuple2::kValue2Offset to define these two
offsets, instead of duplicating the computation and risking offsets going out of
sync.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode10093
src/objects.h:10093: static const int kSize = kBreakPointObjectsIndex +
kPointerSize;
Also the size should not be declared explicitly but "inherited" from Tuple2
IMHO.

https://codereview.chromium.org/2811183005/diff/1/src/objects/literal-objects.h
File src/objects/literal-objects.h (left):

https://codereview.chromium.org/2811183005/diff/1/src/objects/literal-objects...
src/objects/literal-objects.h:43: class ConstantElementsPair : public Struct {
nit: Should inherit from Tuple2 now.

https://codereview.chromium.org/2811183005/diff/1/src/objects/literal-objects...
src/objects/literal-objects.h:55: static const int kConstantValuesOffset =
kElementsKindOffset + kPointerSize;
Likewise.

https://codereview.chromium.org/2811183005/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (left):

https://codereview.chromium.org/2811183005/diff/1/test/cctest/test-debug.cc#o...
test/cctest/test-debug.cc:390: // Iterate the head and check that there are no
debugger related objects left.
nit: s/head/heap/

[Yang, 2017-04-13 11:53:34]

https://codereview.chromium.org/2811183005/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode7491
src/objects.h:7491: class TypeFeedbackInfo: public Struct {
On 2017/04/13 11:25:59, Michael Starzinger wrote:
> nit: Should inherit from Tuple3 now.

Done.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode7513
src/objects.h:7513: static const int kStorage2Offset = kStorage1Offset +
kPointerSize;
On 2017/04/13 11:25:59, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode9837
src/objects.h:9837: class CallHandlerInfo: public Struct {
On 2017/04/13 11:25:58, Michael Starzinger wrote:
> nit: Should inherit from Tuple2 now.

Done.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode9845
src/objects.h:9845: static const int kDataOffset = kCallbackOffset +
kPointerSize;
On 2017/04/13 11:25:59, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode10091
src/objects.h:10091: static const int kBreakPointObjectsIndex =
On 2017/04/13 11:25:59, Michael Starzinger wrote:
> Let's use Tuple2::kValue1Offset and Tuple2::kValue2Offset to define these two
> offsets, instead of duplicating the computation and risking offsets going out
of
> sync.

Done.

https://codereview.chromium.org/2811183005/diff/1/src/objects.h#newcode10093
src/objects.h:10093: static const int kSize = kBreakPointObjectsIndex +
kPointerSize;
On 2017/04/13 11:25:59, Michael Starzinger wrote:
> Also the size should not be declared explicitly but "inherited" from Tuple2
> IMHO.

Done.

https://codereview.chromium.org/2811183005/diff/1/src/objects/literal-objects.h
File src/objects/literal-objects.h (left):

https://codereview.chromium.org/2811183005/diff/1/src/objects/literal-objects...
src/objects/literal-objects.h:43: class ConstantElementsPair : public Struct {
On 2017/04/13 11:25:59, Michael Starzinger wrote:
> nit: Should inherit from Tuple2 now.

Done.

https://codereview.chromium.org/2811183005/diff/1/src/objects/literal-objects...
src/objects/literal-objects.h:55: static const int kConstantValuesOffset =
kElementsKindOffset + kPointerSize;
On 2017/04/13 11:25:59, Michael Starzinger wrote:
> Likewise.

Done.

https://codereview.chromium.org/2811183005/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (left):

https://codereview.chromium.org/2811183005/diff/1/test/cctest/test-debug.cc#o...
test/cctest/test-debug.cc:390: // Iterate the head and check that there are no
debugger related objects left.
On 2017/04/13 11:25:59, Michael Starzinger wrote:
> nit: s/head/heap/

Done.

[Michael Starzinger, 2017-04-13 11:57:12]

LGTM. Thanks!

[Yang, 2017-04-13 12:13:47]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 12:13:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 12:15:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 12:15:43]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/39162)

[Yang, 2017-04-18 12:17:31]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-04-18 12:17:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2811183005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-18 12:17:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 12:46:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492517851289490,
"parent_rev": "c3677c0425c460ac27608d2d053aa8dd784a937a", "commit_rev":
"7b4e4ab70fcd962a3fad3710e0b07ad30d87c765"}

[commit-bot: I haz the power, 2017-04-18 12:46:46]

Description was changed from

==========
Do not use new struct type where unnecessary.

We can use TUPLE2 or TUPLE3 for structs that do not need special
handling by deoptimizer and compiler.

This frees up a few instance types, so that adding the next few
new structs will not cause ABI compatibility to break.


R=mstarzinger@chromium.org
==========

to

==========
Do not use new struct type where unnecessary.

We can use TUPLE2 or TUPLE3 for structs that do not need special
handling by deoptimizer and compiler.

This frees up a few instance types, so that adding the next few
new structs will not cause ABI compatibility to break.


R=mstarzinger@chromium.org

Review-Url: https://codereview.chromium.org/2811183005
Cr-Commit-Position: refs/heads/master@{#44685}
Committed:
https://chromium.googlesource.com/v8/v8/+/7b4e4ab70fcd962a3fad3710e0b07ad30d8...
==========

[commit-bot: I haz the power, 2017-04-18 12:46:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/7b4e4ab70fcd962a3fad3710e0b07ad30d8...