Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2811163002: PaymentHandler: Add a js test for PaymentInstruments get/set methods (Closed)

Created:
3 years, 8 months ago by zino
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentHandler: Add a js test for PaymentInstruments get/set methods Related Spec Link: https://w3c.github.io/webpayments-payment-apps-api/#payment-instruments See the other CLs in this series: [1/3] http://crrev.com/2790013002 (blink side) [2/3] http://crrev.com/2806133002 (content side and unittests) [3/3] http://crrev.com/2811163002 (this patch) BUG=661608 Review-Url: https://codereview.chromium.org/2811163002 Cr-Commit-Position: refs/heads/master@{#464953} Committed: https://chromium.googlesource.com/chromium/src/+/bf32bc709c97515485b41f48c783dab5c5d0d30f

Patch Set 1 #

Patch Set 2 : PaymentHandler: Add a js test for PaymentInstruments get/set methods #

Total comments: 2

Patch Set 3 : nit #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html View 1 2 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
zino
PTAL
3 years, 8 months ago (2017-04-11 19:23:40 UTC) #4
please use gerrit instead
lgtm % nit https://codereview.chromium.org/2811163002/diff/20001/third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html File third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html (right): https://codereview.chromium.org/2811163002/diff/20001/third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html#newcode37 third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html:37: .then (stored_instrument => { No space ...
3 years, 8 months ago (2017-04-11 21:09:38 UTC) #5
Tom Sepez
lgtm
3 years, 8 months ago (2017-04-11 21:52:42 UTC) #6
zino
Thank you for review. I'll wait for other patches to be reviewed. https://codereview.chromium.org/2811163002/diff/20001/third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html File third_party/WebKit/LayoutTests/http/tests/payments/payment-instruments.html ...
3 years, 8 months ago (2017-04-12 16:11:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811163002/60001
3 years, 8 months ago (2017-04-17 17:05:58 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 18:24:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bf32bc709c97515485b41f48c783...

Powered by Google App Engine
This is Rietveld 408576698