Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2811153002: Restore bounds after the screen is restored in clamshell (Closed)

Created:
3 years, 8 months ago by oshima
Modified:
3 years, 8 months ago
Reviewers:
sammiequon
CC:
chromium-reviews, mlamouri+watch-screen-orientation_chromium.org, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore bounds after the screen is restored in clamshell BUG=527631 TEST=covered by unittests. Also tested in the step described in the bug. Review-Url: https://codereview.chromium.org/2811153002 Cr-Commit-Position: refs/heads/master@{#464250} Committed: https://chromium.googlesource.com/chromium/src/+/7973462ca0558fbb68fa455fe45fcd3c98fd277d

Patch Set 1 : Restore bounds after completely transitioned to clamshell. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M ash/display/screen_orientation_controller_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_orientation_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
oshima
3 years, 8 months ago (2017-04-12 23:51:16 UTC) #10
sammiequon
lgtm. Thanks!
3 years, 8 months ago (2017-04-13 00:09:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811153002/20001
3 years, 8 months ago (2017-04-13 00:53:28 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 02:29:02 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7973462ca0558fbb68fa455fe45f...

Powered by Google App Engine
This is Rietveld 408576698