Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2811143004: Revert of Add gesture support in views::ResizeArea (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
tdanderson, sadrul
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add gesture support in views::ResizeArea (patchset #5 id:60001 of https://codereview.chromium.org/2796303006/ ) Reason for revert: Reverting due to consistent failure on Linux Chromium OS ASan LSan Tests: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/ delegate_ = new TestResizeAreaDelegate; in ui/views/controls/resize_area_unittest.cc:118 is the likely culprit. BUG=710771 Original issue's description: > Add gesture support in views::ResizeArea > > Add gesture (touch) support in views::ResizeArea, which > is used for resizing the location bar. This area is located > directly to the right of the location bar. > > BUG=320544 > TEST=manual > > Review-Url: https://codereview.chromium.org/2796303006 > Cr-Commit-Position: refs/heads/master@{#463733} > Committed: https://chromium.googlesource.com/chromium/src/+/6db93d5b7ac95549bea2a1ec2d82cf6c1e8ed58d TBR=sadrul@chromium.org,tdanderson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=320544 Review-Url: https://codereview.chromium.org/2811143004 Cr-Commit-Position: refs/heads/master@{#463993} Committed: https://chromium.googlesource.com/chromium/src/+/2208246074066280fc34229503599484b8ebdb7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -232 lines) Patch
M ui/views/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/resize_area.h View 3 chunks +6 lines, -9 lines 0 comments Download
M ui/views/controls/resize_area.cc View 3 chunks +10 lines, -21 lines 0 comments Download
M ui/views/controls/resize_area_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/controls/resize_area_unittest.cc View 1 chunk +0 lines, -200 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jdoerrie
Created Revert of Add gesture support in views::ResizeArea
3 years, 8 months ago (2017-04-12 11:32:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811143004/1
3 years, 8 months ago (2017-04-12 11:32:20 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 11:34:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2208246074066280fc3422950359...

Powered by Google App Engine
This is Rietveld 408576698