Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2811133002: node_channel.cc: Remove dead code. (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

node_channel.cc: Remove dead code. Found by a Clang warning. BUG=710456 Review-Url: https://codereview.chromium.org/2811133002 Cr-Commit-Position: refs/heads/master@{#463752} Committed: https://chromium.googlesource.com/chromium/src/+/022037f0d183a9d602f7f42accfd4ebf6af80e23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M mojo/edk/system/node_channel.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hans
Please take a look.
3 years, 8 months ago (2017-04-11 18:04:31 UTC) #2
Ken Rockot(use gerrit already)
lgtm
3 years, 8 months ago (2017-04-11 18:17:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811133002/1
3 years, 8 months ago (2017-04-11 18:18:58 UTC) #5
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-11 20:25:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811133002/1
3 years, 8 months ago (2017-04-11 20:28:15 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 20:35:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/022037f0d183a9d602f7f42accfd...

Powered by Google App Engine
This is Rietveld 408576698