Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2811103002: Revert of [date] Add ICU backend for timezone info behind a flag (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich, Yang, Benedikt Meurer, jgruber
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [date] Add ICU backend for timezone info behind a flag (patchset #17 id:320001 of https://codereview.chromium.org/2724373002/ ) Reason for revert: Breaks noi18n: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/13314 Original issue's description: > [date] Add ICU backend for timezone info behind a flag > > This patch implements a timezone backend which is based on ICU, rather > than operating system calls. It can be turned on by passing the > --icu-timezone-data flag. The goal here is to take advantage of ICU's > data, which is more complete than the data that some system calls expose. > For example, without any special code, this patch fixes the time zone > of Lord Howe Island to have a correct 30 minute DST offset, rather than > 60 minutes as the OS backends assume it to have. > > Unfortunately, the parenthized timezone name in Date.prototype.toString() > differs across platforms. This patch chooses the long timezone name, > which matches Windows behavior and might be the most intelligible, but > the web compatibility impact is unclear. > > BUG=v8:6031, v8:2137, v8:6076 > > Review-Url: https://codereview.chromium.org/2724373002 > Cr-Commit-Position: refs/heads/master@{#44562} > Committed: https://chromium.googlesource.com/v8/v8/+/b213f2399038a615cdfbfa0201cddc113d304018 TBR=ulan@chromium.org,jshin@chromium.org,jgruber@chromium.org,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6031, v8:2137, v8:6076 Review-Url: https://codereview.chromium.org/2811103002 Cr-Commit-Position: refs/heads/master@{#44565} Committed: https://chromium.googlesource.com/v8/v8/+/13ad50811024ace5623d5d4d13cea4ef21f4affd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -157 lines) Patch
M src/date.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/date.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/i18n.h View 3 chunks +0 lines, -30 lines 0 comments Download
M src/i18n.cc View 2 chunks +0 lines, -53 lines 0 comments Download
D test/mjsunit/icu-date-lord-howe.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/mjsunit/icu-date-to-string.js View 1 chunk +0 lines, -14 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/testcfg.py View 2 chunks +0 lines, -7 lines 0 comments Download
M tools/testrunner/local/commands.py View 3 chunks +3 lines, -4 lines 0 comments Download
M tools/testrunner/local/execution.py View 3 chunks +3 lines, -5 lines 0 comments Download
M tools/testrunner/objects/testcase.py View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [date] Add ICU backend for timezone info behind a flag
3 years, 8 months ago (2017-04-11 12:07:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811103002/1
3 years, 8 months ago (2017-04-11 12:07:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/13ad50811024ace5623d5d4d13cea4ef21f4affd
3 years, 8 months ago (2017-04-11 12:07:37 UTC) #6
Dan Ehrenberg
3 years, 8 months ago (2017-04-11 12:31:19 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2813863002/ by littledan@chromium.org.

The reason for reverting is: Reland with tests marked as off in no-i18n mode.

Powered by Google App Engine
This is Rietveld 408576698