[regexp] Address various minor nits

[regexp] Address various minor nits

* Use BIND, VARIABLE macros everywhere.
* Unify fast path check functions.
* Asserts in CSA::StringCharCodeAt.

BUG=

Review-Url: https://codereview.chromium.org/2811063003
Cr-Commit-Position: refs/heads/master@{#44553}
Committed: https://chromium.googlesource.com/v8/v8/+/0bd06a23719b77a3c77e3c0eb88915a5679cb76a

[jgruber, 2017-04-11 08:13:45]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:13:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 08:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 08:16:26]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[jgruber, 2017-04-11 08:23:05]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:23:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-11 08:31:50]

jgruber@chromium.org changed reviewers:
+ cbruni@chromium.org

[commit-bot: I haz the power, 2017-04-11 08:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 08:52:17]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2017-04-11 09:21:14]

LGTM with nits

https://codereview.chromium.org/2811063003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp-gen.cc (right):

https://codereview.chromium.org/2811063003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp-gen.cc:698: CSA_ASSERT(this,
TaggedIsNotSmi(object));
Probably even: IsJSReceiver(object)

https://codereview.chromium.org/2811063003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp-gen.cc:743: CSA_ASSERT(this,
TaggedIsNotSmi(object));
same here

[jgruber, 2017-04-11 09:57:24]

https://codereview.chromium.org/2811063003/diff/20001/src/builtins/builtins-r...
File src/builtins/builtins-regexp-gen.cc (right):

https://codereview.chromium.org/2811063003/diff/20001/src/builtins/builtins-r...
src/builtins/builtins-regexp-gen.cc:698: CSA_ASSERT(this,
TaggedIsNotSmi(object));
On 2017/04/11 09:21:13, Camillo Bruni wrote:
> Probably even: IsJSReceiver(object)

All I want to assert here is that we can load a map from the object, so
TaggedIsNotSmi seems more appropriate.

[jgruber, 2017-04-11 09:57:43]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-04-11 09:57:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 10:00:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491904663947880,
"parent_rev": "64173571eb3852eff63ff010dccd94d603adb278", "commit_rev":
"0bd06a23719b77a3c77e3c0eb88915a5679cb76a"}

[commit-bot: I haz the power, 2017-04-11 10:00:15]

Description was changed from

==========
[regexp] Address various minor nits

* Use BIND, VARIABLE macros everywhere.
* Unify fast path check functions.
* Asserts in CSA::StringCharCodeAt.

BUG=
==========

to

==========
[regexp] Address various minor nits

* Use BIND, VARIABLE macros everywhere.
* Unify fast path check functions.
* Asserts in CSA::StringCharCodeAt.

BUG=

Review-Url: https://codereview.chromium.org/2811063003
Cr-Commit-Position: refs/heads/master@{#44553}
Committed:
https://chromium.googlesource.com/v8/v8/+/0bd06a23719b77a3c77e3c0eb88915a5679...
==========

[commit-bot: I haz the power, 2017-04-11 10:00:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0bd06a23719b77a3c77e3c0eb88915a5679...