Issue 2811033: [Isolates] Remove even more statics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2811033: [Isolates] Remove even more statics. (Closed)

Created:
10 years, 6 months ago by zarko

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko, Dmitry Titov

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/isolates/

Visibility:
Public.

Description

[Isolates] Remove even more statics. Committed: http://code.google.com/p/v8/source/detail?r=4955

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase and address comments #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -90 lines)			Patch
M	src/arm/codegen-arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/execution.cc	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/isolate.h	View	1	5 chunks	+33 lines, -1 line	0 comments	Download
M	src/jsregexp.h	View	1	2 chunks	+5 lines, -8 lines	0 comments	Download
M	src/jsregexp.cc	View	1	22 chunks	+35 lines, -28 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/objects.cc	View	1	12 chunks	+32 lines, -30 lines	0 comments	Download
M	src/objects-inl.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/profile-generator.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/profile-generator.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/profile-generator-inl.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/disasm-x64.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 6 months ago (2010-06-25 13:35:45 UTC) #2

LGTM

http://codereview.chromium.org/2811033/diff/1/7
File src/isolate.h (right):

http://codereview.chromium.org/2811033/diff/1/7#newcode181
src/isolate.h:181: V(int, jsregexp_static_offsets_vector,
kJsRegexpStaticOffsetsVectorSize)
nit: s/Js/JS

http://codereview.chromium.org/2811033/diff/1/7#newcode199
src/isolate.h:199: V(unsigned, code_entry_next_call_uid, NULL)                  
               \
Needs a comment.

http://codereview.chromium.org/2811033/diff/1/7#newcode575
src/isolate.h:575: static const int kJsRegexpStaticOffsetsVectorSize = 50;
nit: s/Js/JS

http://codereview.chromium.org/2811033/diff/1/11
File src/objects.cc (right):

http://codereview.chromium.org/2811033/diff/1/11#newcode4663
src/objects.cc:4663: static inline bool CompareStringContentsPartial(Isolate*
isolate, IteratorA* ia,
nit: Please reformat to have one arg per line.

Expand Messages | Collapse Messages