Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: src/ia32/disasm-ia32.cc

Issue 2811033: [Isolates] Remove even more statics. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/isolates/
Patch Set: rebase and address comments Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2007-2008 the V8 project authors. All rights reserved. 1 // Copyright 2007-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 void InstructionTable::AddJumpConditionalShort() { 235 void InstructionTable::AddJumpConditionalShort() {
236 for (byte b = 0x70; b <= 0x7F; b++) { 236 for (byte b = 0x70; b <= 0x7F; b++) {
237 InstructionDesc* id = &instructions_[b]; 237 InstructionDesc* id = &instructions_[b];
238 ASSERT_EQ(NO_INSTR, id->type); // Information not already entered. 238 ASSERT_EQ(NO_INSTR, id->type); // Information not already entered.
239 id->mnem = jump_conditional_mnem[b & 0x0F]; 239 id->mnem = jump_conditional_mnem[b & 0x0F];
240 id->type = JUMP_CONDITIONAL_SHORT_INSTR; 240 id->type = JUMP_CONDITIONAL_SHORT_INSTR;
241 } 241 }
242 } 242 }
243 243
244 244
245 // TODO(isolates): This appears to act morally as a constant. Is it safe?
246 static InstructionTable instruction_table; 245 static InstructionTable instruction_table;
247 246
248 247
249 // The IA32 disassembler implementation. 248 // The IA32 disassembler implementation.
250 class DisassemblerIA32 { 249 class DisassemblerIA32 {
251 public: 250 public:
252 DisassemblerIA32(const NameConverter& converter, 251 DisassemblerIA32(const NameConverter& converter,
253 bool abort_on_unimplemented = true) 252 bool abort_on_unimplemented = true)
254 : converter_(converter), 253 : converter_(converter),
255 tmp_buffer_pos_(0), 254 tmp_buffer_pos_(0),
(...skipping 1206 matching lines...) Expand 10 before | Expand all | Expand 10 after
1462 fprintf(f, " "); 1461 fprintf(f, " ");
1463 } 1462 }
1464 fprintf(f, " %s\n", buffer.start()); 1463 fprintf(f, " %s\n", buffer.start());
1465 } 1464 }
1466 } 1465 }
1467 1466
1468 1467
1469 } // namespace disasm 1468 } // namespace disasm
1470 1469
1471 #endif // V8_TARGET_ARCH_IA32 1470 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698