Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2810943007: Allow sync to resume in local backend mode after it has been disabled. (Closed)

Created:
3 years, 8 months ago by pastarmovj
Modified:
3 years, 8 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow sync to resume in local backend mode after it has been disabled. If sync has been disabled manually or by policy it was not resuming in local sync mode afterwards because there is no external event to trigger that. BUG=707181 TEST=components_unittests Review-Url: https://codereview.chromium.org/2810943007 Cr-Commit-Position: refs/heads/master@{#466926} Committed: https://chromium.googlesource.com/chromium/src/+/f51a09272db6c06dcca92fa0e2c4811dc8d5e828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M components/browser_sync/profile_sync_service.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_unittest.cc View 2 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 20 (12 generated)
pastarmovj
Hi Pavel, please take a look at this fix for an issue with the interplay ...
3 years, 8 months ago (2017-04-13 15:13:04 UTC) #4
pavely
lgtm
3 years, 8 months ago (2017-04-13 21:40:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810943007/1
3 years, 8 months ago (2017-04-24 09:06:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/437266)
3 years, 8 months ago (2017-04-24 11:35:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810943007/1
3 years, 8 months ago (2017-04-24 12:45:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/437337)
3 years, 8 months ago (2017-04-24 15:25:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810943007/1
3 years, 8 months ago (2017-04-25 08:07:21 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 08:33:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f51a09272db6c06dcca92fa0e2c4...

Powered by Google App Engine
This is Rietveld 408576698