Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2810943005:
Add a presubmit script to check if eventSender still be used for new layout tests (Closed)
DescriptionAdd a presubmit script to check if eventSender still be used for new layout tests.
In order to encourage new layout tests to use chrome.gpuBenchmarking.pointerActionSequence
instead of eventSender, we add a presubmit script to check if eventSender is still used in the new layout tests.
This also helps us to slowly replace eventSender in the current layout tests.
BUG=711340
Review-Url: https://codereview.chromium.org/2810943005
Cr-Commit-Position: refs/heads/master@{#466001}
Committed: https://chromium.googlesource.com/chromium/src/+/a15a2d8062d9919bef96f18455a062a920f4568a
Patch Set 1 : upload check #Patch Set 2 : check new file for mouse, touch, gesture #
Total comments: 2
Patch Set 3 : reword comments #Messages
Total messages: 31 (24 generated)
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== upload check BUG= ========== to ========== Add a presubmit script to check if eventSender still be used for new layout tests. In order to encourage new layout tests to use chrome.gpuBenchmarking.pointerActionSequence instead of eventSender, we add a presubmit script to check if eventSender is still used in the new layout tests. This also helps us to slowly replace eventSender in the current layout tests. BUG=711340 ==========
lanwei@chromium.org changed reviewers: + dtapuska@chromium.org, tdresser@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
This appears to be triggering without modifying any layouttests. I think it would be better to start off only caring about new files, not modified files. If that works out, we could start also including modified files.
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #2 (id:10002) has been deleted
LGTM with nits. https://codereview.chromium.org/2810943005/diff/50001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2810943005/diff/50001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/PRESUBMIT.py:91: """Check if the new layout tests or changed layout tests still use eventSender. If they do, Update comment to reflect that we no longer include changed layout tests. https://codereview.chromium.org/2810943005/diff/50001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/PRESUBMIT.py:101: 'Files that still uses eventSender: %s:%d %s, please use chrome.gpuBenchmarking.pointerActionSequence instead.' % uses -> use
lgtm % nits tdresser pointed out.
The CQ bit was checked by lanwei@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lanwei@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dtapuska@chromium.org, tdresser@chromium.org Link to the patchset: https://codereview.chromium.org/2810943005/#ps70001 (title: "reword comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 70001, "attempt_start_ts": 1492697747748470,
"parent_rev": "9370d31a7691f37c1ae4837151b8ab3438f4d33e", "commit_rev":
"a15a2d8062d9919bef96f18455a062a920f4568a"}
Message was sent while issue was closed.
Description was changed from ========== Add a presubmit script to check if eventSender still be used for new layout tests. In order to encourage new layout tests to use chrome.gpuBenchmarking.pointerActionSequence instead of eventSender, we add a presubmit script to check if eventSender is still used in the new layout tests. This also helps us to slowly replace eventSender in the current layout tests. BUG=711340 ========== to ========== Add a presubmit script to check if eventSender still be used for new layout tests. In order to encourage new layout tests to use chrome.gpuBenchmarking.pointerActionSequence instead of eventSender, we add a presubmit script to check if eventSender is still used in the new layout tests. This also helps us to slowly replace eventSender in the current layout tests. BUG=711340 Review-Url: https://codereview.chromium.org/2810943005 Cr-Commit-Position: refs/heads/master@{#466001} Committed: https://chromium.googlesource.com/chromium/src/+/a15a2d8062d9919bef96f18455a0... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:70001) as https://chromium.googlesource.com/chromium/src/+/a15a2d8062d9919bef96f18455a0... |
