Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2810943004: Update Recent Tabs string to title case (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, srahim+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Recent Tabs string to title case This CL adds a meaning field to the "Recent Tabs" string. It allows disambiguation with the other "Recent Tabs" strings, incorrectly translated. BUG=710833 Review-Url: https://codereview.chromium.org/2810943004 Cr-Commit-Position: refs/heads/master@{#464012} Committed: https://chromium.googlesource.com/chromium/src/+/b3f6bfc64c3ab48d05200ca4890657150d6529f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-12 13:30:19 UTC) #2
stkhapugin
lgtm
3 years, 8 months ago (2017-04-12 13:59:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810943004/1
3 years, 8 months ago (2017-04-12 13:59:20 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 14:05:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b3f6bfc64c3ab48d05200ca48906...

Powered by Google App Engine
This is Rietveld 408576698