Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2810923002: [Chromecast] Build with check-ipc clang plugin flag on Chromecast. (Closed)

Created:
3 years, 8 months ago by mbjorge
Modified:
3 years, 8 months ago
Reviewers:
slan, jam, Simeon, scottmg
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Build with check-ipc clang plugin flag on Chromecast. Increase build parity between chromecast and non-chromecast build. Also adds more checks. Internal builds all compiled without issue. BUG=581409 , internal b/37211660 Review-Url: https://codereview.chromium.org/2810923002 Cr-Commit-Position: refs/heads/master@{#463515} Committed: https://chromium.googlesource.com/chromium/src/+/be7bac4630c397e4cb8773fc93e1c559c3bfebdb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/config/clang/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mbjorge
+sanfin as fyi, since this check was originally added primarily for Android things
3 years, 8 months ago (2017-04-10 20:32:52 UTC) #2
slan
lgtm
3 years, 8 months ago (2017-04-10 21:57:36 UTC) #4
jam
please pick a build/config owner
3 years, 8 months ago (2017-04-11 01:12:40 UTC) #5
mbjorge
+scottmg as build/config OWNER
3 years, 8 months ago (2017-04-11 01:18:12 UTC) #7
scottmg
lgtm
3 years, 8 months ago (2017-04-11 01:18:44 UTC) #8
mbjorge
3 years, 8 months ago (2017-04-11 01:25:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810923002/1
3 years, 8 months ago (2017-04-11 01:26:17 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 03:22:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be7bac4630c397e4cb8773fc93e1...

Powered by Google App Engine
This is Rietveld 408576698