Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2810913008:
Add //chromeos dependency in //extensions/browser/api/networking_private (Closed)
|
Created:
3 years, 8 months ago by vabr (Chromium) Modified:
3 years, 8 months ago CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, stevenjb+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd //chromeos dependency in //extensions/browser/api/networking_private
A couple of *chromeos* files in networking_private include headers from
//chromeos/network, but do not declare their target as dependency. This might
be causing compile flakes described on the bug.
BUG=710757
TBR=finnur@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2810913008
Cr-Commit-Position: refs/heads/master@{#463940}
Committed: https://chromium.googlesource.com/chromium/src/+/9728f347af4ee2c9d1778ef3813193fa02790d8d
Patch Set 1 #Patch Set 2 : Restrict compilation to CrOS #Messages
Total messages: 20 (14 generated)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vabr@chromium.org changed reviewers: + jochen@chromium.org
Hi Jochen, I'm seeking an expert opinion -- does this make sense to you? Cheers, Vaclav
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vabr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yes, like this this lgtm
Description was changed from ========== Add //chromeos dependency in //extensions/browser/api/networking_private A couple of *chromeos* files in networking_private include headers from //chromeos/network, but do not declare their target as dependency. This might be causing compile flakes described on the bug. BUG=710757 ========== to ========== Add //chromeos dependency in //extensions/browser/api/networking_private A couple of *chromeos* files in networking_private include headers from //chromeos/network, but do not declare their target as dependency. This might be causing compile flakes described on the bug. BUG=710757 TBR=finnur@chromium.org ==========
vabr@chromium.org changed reviewers: + finnur@chromium.org
Description was changed from ========== Add //chromeos dependency in //extensions/browser/api/networking_private A couple of *chromeos* files in networking_private include headers from //chromeos/network, but do not declare their target as dependency. This might be causing compile flakes described on the bug. BUG=710757 TBR=finnur@chromium.org ========== to ========== Add //chromeos dependency in //extensions/browser/api/networking_private A couple of *chromeos* files in networking_private include headers from //chromeos/network, but do not declare their target as dependency. This might be causing compile flakes described on the bug. BUG=710757 TBR=finnur@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true ==========
Thanks, Jochen! I am TBR-ing finnur@, for extensions owner review, and landing now, because this is blocking reopening the tree. Finnur -- I'm more than happy to do follow-ups should you have any comments, or if you want me to talk to other people on the extensions team which are responsible for this particular part. Cheers, Vaclav
The CQ bit was unchecked by vabr@chromium.org
The CQ bit was checked by vabr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491981991791750,
"parent_rev": "d7eaf476075d774e835fc0310be0557ccf4b2b9e", "commit_rev":
"9728f347af4ee2c9d1778ef3813193fa02790d8d"}
Message was sent while issue was closed.
Description was changed from ========== Add //chromeos dependency in //extensions/browser/api/networking_private A couple of *chromeos* files in networking_private include headers from //chromeos/network, but do not declare their target as dependency. This might be causing compile flakes described on the bug. BUG=710757 TBR=finnur@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true ========== to ========== Add //chromeos dependency in //extensions/browser/api/networking_private A couple of *chromeos* files in networking_private include headers from //chromeos/network, but do not declare their target as dependency. This might be causing compile flakes described on the bug. BUG=710757 TBR=finnur@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2810913008 Cr-Commit-Position: refs/heads/master@{#463940} Committed: https://chromium.googlesource.com/chromium/src/+/9728f347af4ee2c9d1778ef38131... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9728f347af4ee2c9d1778ef38131...
Message was sent while issue was closed.
LGTM |
