Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2810873009:
DevTools: Add padding to toolbar buttons with dropdown arrows (Closed)
|
Created:
3 years, 8 months ago by einbinder Modified:
3 years, 8 months ago Reviewers:
dgozman CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Add padding to toolbar buttons with dropdown arrows
The focus highlight was too flush against the dropdown arrow
BUG=709863
Review-Url: https://codereview.chromium.org/2810873009
Cr-Commit-Position: refs/heads/master@{#464443}
Committed: https://chromium.googlesource.com/chromium/src/+/1c3daf0c551326e7ed682311a93c486fc54fe7f5
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 19 (10 generated)
einbinder@chromium.org changed reviewers: + dgozman@chromium.org
ptal
lgtm
The CQ bit was checked by einbinder@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2815983002 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492100723638970, "parent_rev":
"4206beae5ebdd5301172c3276aac23a92bdc414f", "commit_rev":
"1c3daf0c551326e7ed682311a93c486fc54fe7f5"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: Add padding to toolbar buttons with dropdown arrows The focus highlight was too flush against the dropdown arrow BUG=709863 ========== to ========== DevTools: Add padding to toolbar buttons with dropdown arrows The focus highlight was too flush against the dropdown arrow BUG=709863 Review-Url: https://codereview.chromium.org/2810873009 Cr-Commit-Position: refs/heads/master@{#464443} Committed: https://chromium.googlesource.com/chromium/src/+/1c3daf0c551326e7ed682311a93c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1c3daf0c551326e7ed682311a93c... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
