Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutPart.h

Issue 2810873007: Replace LayoutPart::GetFrameViewBase with GetNodeFrameView (Closed)
Patch Set: No need for child_frame_view var Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutPart.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutPart.h b/third_party/WebKit/Source/core/layout/LayoutPart.h
index 1d2f1253a4d616a90642ecea9c3b299baa323a88..0a42bcde8492917be84502be29c512b7da39d35f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutPart.h
+++ b/third_party/WebKit/Source/core/layout/LayoutPart.h
@@ -49,12 +49,12 @@ class CORE_EXPORT LayoutPart : public LayoutReplaced {
void Ref() { ++ref_count_; }
void Deref();
- FrameViewBase* GetFrameViewBase() const;
+ // LayoutPart::ChildFrameView returns the FrameView associated with
+ // the current Node, if Node is HTMLFrameOwnerElement.
+ // This is different to LayoutObject::GetFrameView which returns
+ // the FrameView associated with the root Document Frame.
+ FrameView* ChildFrameView() const;
PluginView* Plugin() const;
- // TODO(joelhockey): This method will be removed once FrameViewBase
- // class is removed. New abstract base classes will be defined
- // for when polymorphism is required for plugins and frames and
- // other methods provided.
FrameViewBase* PluginOrFrame() const;
LayoutRect ReplacedContentRect() const final;
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutPart.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698