third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp - Issue 2810873007: Replace LayoutPart::GetFrameViewBase with GetNodeFrameView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp

Issue 2810873007: Replace LayoutPart::GetFrameViewBase with GetNodeFrameView (Closed)

Patch Set: No need for child_frame_view var Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp

index 9263bd578574b120dbb607dc3552329a72f4d36a..e19d3466670bc9761d8beb648eca660d2e109b37 100644

--- a/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp

@@ -157,9 +157,9 @@ CompositingReasons LayoutEmbeddedObject::AdditionalCompositingReasons() const {

}

LayoutReplaced* LayoutEmbeddedObject::EmbeddedReplacedContent() const {

- if (!GetNode() || !GetFrameViewBase() || !GetFrameViewBase()->IsFrameView())

- return nullptr;

- return ToFrameView(GetFrameViewBase())->EmbeddedReplacedContent();

+ if (FrameView* frame_view = ChildFrameView())

+ return frame_view->EmbeddedReplacedContent();

+ return nullptr;

}

} // namespace blink