Replace LayoutPart::GetFrameViewBase with GetNodeFrameView

third_party/WebKit/Source/core/layout/LayoutPart.h

Index: third_party/WebKit/Source/core/layout/LayoutPart.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutPart.h b/third_party/WebKit/Source/core/layout/LayoutPart.h
index a1577ce4da93bd9cad4c391284e2797a97f7e311..71fe72f908be4c490658baea45412d75e0c668a8 100644
--- a/third_party/WebKit/Source/core/layout/LayoutPart.h
+++ b/third_party/WebKit/Source/core/layout/LayoutPart.h
@@ -49,12 +49,12 @@ class CORE_EXPORT LayoutPart : public LayoutReplaced {
   void Ref() { ++ref_count_; }
   void Deref();
 
-  FrameViewBase* GetFrameViewBase() const;
+  // LayoutPart::GetNodeFrameView returns the FrameView associated with
+  // the current Node, if Node is HTMLFrameOwnerElement.
+  // This is different to LayoutObject::GetFrameView which returns
+  // the FrameView associated with the root Document Frame.

[haraken, 2017/04/12 07:21:01]

I'm wondering when the two FrameViews can differ.

dcheng@: Do you have any insight?

[dcheng, 2017/04/12 23:44:37]

The difference is kind of subtle, but my understanding is:

LayoutObject::GetFrameView -> returns the containing Document's Frame's
FrameView. This is the frame that the LayoutObject is in, i.e. the parent frame.

LayoutPart::GetNodeFrameView -> returns the contained Document's Frame's
FrameView. This is the FrameView for the child frame.

+  FrameView* GetNodeFrameView() const;
   PluginView* Plugin() const;
-  // TODO(joelhockey): This method will be removed once FrameViewBase
-  // class is removed.  New abstract base classes will be defined
-  // for when polymorphism is required for plugins and frames and
-  // other methods provided.
   FrameViewBase* PluginOrFrame() const;
 
   LayoutRect ReplacedContentRect() const final;