Replace LayoutPart::GetFrameViewBase with GetNodeFrameView

third_party/WebKit/Source/core/layout/LayoutPart.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Simon Hausmann <hausmann@kde.org>
  * Copyright (C) 2006, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 31 matching lines @@
   bool NeedsPreferredWidthsRecalculation() const final;
 
   bool NodeAtPoint(HitTestResult&,
                    const HitTestLocation& location_in_container,
                    const LayoutPoint& accumulated_offset,
                    HitTestAction) override;
 
   void Ref() { ++ref_count_; }
   void Deref();
 
-  FrameViewBase* GetFrameViewBase() const;
+  // LayoutPart::GetNodeFrameView returns the FrameView associated with
+  // the current Node, if Node is HTMLFrameOwnerElement.
+  // This is different to LayoutObject::GetFrameView which returns
+  // the FrameView associated with the root Document Frame.

[haraken, 2017/04/12 07:21:01]

I'm wondering when the two FrameViews can differ.

dcheng@: Do you have any insight?

[dcheng, 2017/04/12 23:44:37]

The difference is kind of subtle, but my understanding is:

LayoutObject::GetFrameView -> returns the containing Document's Frame's
FrameView. This is the frame that the LayoutObject is in, i.e. the parent frame.

LayoutPart::GetNodeFrameView -> returns the contained Document's Frame's
FrameView. This is the FrameView for the child frame.

+  FrameView* GetNodeFrameView() const;
   PluginView* Plugin() const;
-  // TODO(joelhockey): This method will be removed once FrameViewBase
-  // class is removed.  New abstract base classes will be defined
-  // for when polymorphism is required for plugins and frames and
-  // other methods provided.
   FrameViewBase* PluginOrFrame() const;
 
   LayoutRect ReplacedContentRect() const final;
 
   void UpdateOnWidgetChange();
   void UpdateGeometry();
 
   bool IsLayoutPart() const final { return true; }
   virtual void PaintContents(const PaintInfo&, const LayoutPoint&) const;
 
@@ skipping 25 matching lines @@
       HitTestAction);
 
   int ref_count_;
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutPart, IsLayoutPart());
 
 }  // namespace blink
 
 #endif  // LayoutPart_h