DevTools: fix memory issue with layout test

DevTools: fix memory issue with layout test

No longer using unique_ptr to manage the lifetime of devtools_window_ because
the Shell object is currently getting deleted twice (once from Shell::CloseAllWindows and
once by the unique_ptr).

BUG=710356
Review-Url: https://codereview.chromium.org/2810873006
Cr-Commit-Position: refs/heads/master@{#464156}
Committed: https://chromium.googlesource.com/chromium/src/+/cfaf69d33ef9a51db827b68edee25553ab39f797

[chenwilliam, 2017-04-12 01:31:37]

chenwilliam@chromium.org changed reviewers:
+ dgozman@chromium.org

[chenwilliam, 2017-04-12 01:31:38]

Please take a look. I caused a memory issue from the earlier refactoring and
it's a beta blocker :(

[dgozman, 2017-04-12 16:59:25]

lgtm

https://codereview.chromium.org/2810873006/diff/1/content/shell/browser/layou...
File content/shell/browser/layout_test/blink_test_controller.cc (right):

https://codereview.chromium.org/2810873006/diff/1/content/shell/browser/layou...
content/shell/browser/layout_test/blink_test_controller.cc:519:
devtools_window_->Close();
devtools_window_ = nullptr;

[chenwilliam, 2017-04-12 18:25:22]

The CQ bit was checked by chenwilliam@chromium.org

[chenwilliam, 2017-04-12 18:25:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2810873006/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2017-04-12 18:26:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 21:29:25]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492021522985390,
"parent_rev": "2b8dd2d1d8c2c17e5715853ad74cf2891b3c87c7", "commit_rev":
"cfaf69d33ef9a51db827b68edee25553ab39f797"}

[commit-bot: I haz the power, 2017-04-12 21:31:25]

Description was changed from

==========
DevTools: fix memory issue with layout test

No longer using unique_ptr to manage the lifetime of devtools_window_ because
the Shell object is currently getting deleted twice (once from
Shell::CloseAllWindows and
once by the unique_ptr).

BUG=710356
==========

to

==========
DevTools: fix memory issue with layout test

No longer using unique_ptr to manage the lifetime of devtools_window_ because
the Shell object is currently getting deleted twice (once from
Shell::CloseAllWindows and
once by the unique_ptr).

BUG=710356

Review-Url: https://codereview.chromium.org/2810873006
Cr-Commit-Position: refs/heads/master@{#464156}
Committed:
https://chromium.googlesource.com/chromium/src/+/cfaf69d33ef9a51db827b68edee2...
==========

[commit-bot: I haz the power, 2017-04-12 21:31:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cfaf69d33ef9a51db827b68edee2...