Issue 2810873003: [Desktop FRE] Do not show Welcome if sign-in disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2810873003: [Desktop FRE] Do not show Welcome if sign-in disabled (Closed)

Created:
3 years, 8 months ago by tmartino

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

[Desktop FRE] Do not show Welcome if sign-in disabled BUG=702576 Review-Url: https://codereview.chromium.org/2786883008 Cr-Commit-Position: refs/heads/master@{#462636} (cherry picked from commit cab3dfe03ca689d5eb085e7a06418e22cbf31a42) Review-Url: https://codereview.chromium.org/2810873003 . Cr-Commit-Position: refs/branch-heads/3029@{#655} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/0c5c1e36cde0084f2be1ef0bc68dd89cd621b3cc

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -23 lines)			Patch
M	chrome/browser/ui/startup/startup_tab_provider.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_tab_provider.cc	View	5 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/startup/startup_tab_provider_unittest.cc	View	12 chunks	+30 lines, -18 lines	0 comments	Download

Total messages: 2 (1 generated)

tmartino

3 years, 8 months ago (2017-04-10 21:36:25 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0c5c1e36cde0084f2be1ef0bc68dd89cd621b3cc.