Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2810873002: WebUI: Fix cr-action-menu opening outside of layout. (Closed)

Created:
3 years, 8 months ago by scottchen
Modified:
3 years, 8 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Fix cr-action-menu opening outside of layout. BUG=709938 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2810873002 Cr-Commit-Position: refs/heads/master@{#463887} Committed: https://chromium.googlesource.com/chromium/src/+/f416ef84abd82d7c45713fa69e8b44787251bf67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
scottchen
3 years, 8 months ago (2017-04-10 19:02:37 UTC) #4
dpapad
lgtm
3 years, 8 months ago (2017-04-10 19:23:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810873002/1
3 years, 8 months ago (2017-04-12 00:25:44 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 01:46:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f416ef84abd82d7c45713fa69e8b...

Powered by Google App Engine
This is Rietveld 408576698