Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2810863003: Android: Remove GetApplicationContext: components/ (Closed)

Created:
3 years, 8 months ago by Peter Wen
Modified:
3 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, vakh+watch_chromium.org, zea+watch_chromium.org, Peter Beverloo, grt+watch_chromium.org, johnme+watch_chromium.org, timvolodine, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Remove GetApplicationContext: components/ base/android/context_utils.* is being removed. Java-side already has the ContextUtils#GetApplicationContext global and no longer needs native to hold the pointer and pass it through jni with every call that needs an application context. BUG=646094 Review-Url: https://codereview.chromium.org/2810863003 Cr-Commit-Position: refs/heads/master@{#465616} Committed: https://chromium.googlesource.com/chromium/src/+/ff6a1da8d92c61fe4e8f15d1ee070faa4cb60e40

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -85 lines) Patch
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java View 2 chunks +5 lines, -10 lines 0 comments Download
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GoogleCloudMessagingV2.java View 6 chunks +7 lines, -8 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 2 chunks +1 line, -5 lines 0 comments Download
M components/gcm_driver/instance_id/android/java/src/org/chromium/components/gcm_driver/instance_id/InstanceIDBridge.java View 5 chunks +6 lines, -9 lines 0 comments Download
M components/gcm_driver/instance_id/instance_id_android.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/safe_browsing_db/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiBridge.java View 3 chunks +9 lines, -9 lines 0 comments Download
M components/safe_browsing_db/android/safe_browsing_api_handler_bridge.cc View 3 chunks +1 line, -4 lines 0 comments Download
M components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedBridge.java View 7 chunks +16 lines, -18 lines 0 comments Download
M components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedFetcher.java View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/android/junit/src/org/chromium/components/variations/firstrun/VariationsSeedFetcherTest.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/android/variations_seed_bridge.cc View 5 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Peter Wen
Hi Sylvain, PTAL, see part 1 here: http://crrev.com/2772343003 part 2: http://crrev.com/2799263002 Thanks.
3 years, 8 months ago (2017-04-10 21:09:12 UTC) #4
sdefresne
On 2017/04/10 21:09:12, Peter Wen wrote: > Hi Sylvain, > > PTAL, see part 1 ...
3 years, 8 months ago (2017-04-11 07:52:43 UTC) #7
Peter Wen
Thanks! PTAL, bots are now green. :)
3 years, 8 months ago (2017-04-12 14:16:40 UTC) #12
Peter Wen
Friendly ping as it's been a week, thanks!
3 years, 8 months ago (2017-04-19 13:47:18 UTC) #13
sdefresne
rs lgtm
3 years, 8 months ago (2017-04-19 13:50:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810863003/20001
3 years, 8 months ago (2017-04-19 13:58:11 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 15:34:42 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ff6a1da8d92c61fe4e8f15d1ee07...

Powered by Google App Engine
This is Rietveld 408576698