Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)
Patch Set: Adjust even more tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
index 3ce3c0c60fa24eb3c582836af913cf34c43a5e32..1d6f4169be04324378971bfd6601147e77d3f2aa 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
@@ -30,6 +30,8 @@
#include "bindings/core/v8/V8MessageEvent.h"
+#include "bindings/core/v8/IDLTypes.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
#include "bindings/core/v8/SerializedScriptValue.h"
#include "bindings/core/v8/SerializedScriptValueFactory.h"
#include "bindings/core/v8/V8ArrayBuffer.h"
@@ -119,9 +121,8 @@ void V8MessageEvent::initMessageEventMethodCustom(
const int kPortArrayIndex = 7;
if (!IsUndefinedOrNull(info[kPortArrayIndex])) {
port_array = new MessagePortArray;
- *port_array = ToMemberNativeArray<MessagePort>(
- info[kPortArrayIndex], kPortArrayIndex + 1, info.GetIsolate(),
- exception_state);
+ *port_array = NativeValueTraits<IDLSequence<MessagePort>>::NativeValue(
+ info.GetIsolate(), info[kPortArrayIndex], exception_state);
if (exception_state.HadException())
return;
}
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8BindingTest.cpp ('k') | third_party/WebKit/Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698