third_party/WebKit/Source/bindings/scripts/v8_methods.py - Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_methods.py

Issue 2810843002: bindings: Make the sequence conversion code more complaint with WebIDL. (Closed)

Patch Set: Adjust even more tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_methods.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_methods.py b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

index 97f74ac844e04281d59555bbc8208cc294173cd3..fa613df7b043d9ddd2ce8f550daec0bbc260d9d4 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_methods.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_methods.py

@@ -377,7 +377,7 @@ def v8_value_to_local_cpp_value(method, argument, index, return_promise=False):

if argument.is_variadic:

return v8_value_to_local_cpp_variadic_value(method, argument, index, return_promise)

return idl_type.v8_value_to_local_cpp_value(extended_attributes, 'info[%s]' % index,

- name, index=index, declare_variable=False,

+ name, declare_variable=False,

use_exception_state=method.returns_promise)