Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2810823002: Drop shess from safe-browsing OWNERS. (Closed)

Created:
3 years, 8 months ago by Scott Hess - ex-Googler
Modified:
3 years, 8 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org, vakh+watch_chromium.org, timvolodine
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop shess from safe-browsing OWNERS. Cleaning up before I head off into the sunset. BUG=none R=nparker@chromium.org Review-Url: https://codereview.chromium.org/2810823002 Cr-Commit-Position: refs/heads/master@{#463341} Committed: https://chromium.googlesource.com/chromium/src/+/c694aa0db08db59679ff65171b05b1d228f3c189

Patch Set 1 #

Total comments: 3

Patch Set 2 : reviewers per nparker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/browser/safe_browsing/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/safe_browsing/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/safe_browsing/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Scott Hess - ex-Googler
I'm hoping to maintain committer status, but I'm also hoping to keep to a once-a-week ...
3 years, 8 months ago (2017-04-10 17:00:40 UTC) #1
Scott Hess - ex-Googler
I'm hoping to maintain committer status, but I'm also hoping to keep to a once-a-week ...
3 years, 8 months ago (2017-04-10 17:00:41 UTC) #2
Nathan Parker
Thanks Scott. LGTM with adjustments https://codereview.chromium.org/2810823002/diff/1/chrome/common/safe_browsing/OWNERS File chrome/common/safe_browsing/OWNERS (right): https://codereview.chromium.org/2810823002/diff/1/chrome/common/safe_browsing/OWNERS#newcode3 chrome/common/safe_browsing/OWNERS:3: nparker@chromium.org add vakh@ https://codereview.chromium.org/2810823002/diff/1/chrome/renderer/safe_browsing/OWNERS ...
3 years, 8 months ago (2017-04-10 17:49:37 UTC) #3
Scott Hess - ex-Googler
reviewers per nparker
3 years, 8 months ago (2017-04-10 18:23:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810823002/20001
3 years, 8 months ago (2017-04-10 18:29:47 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 18:42:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c694aa0db08db59679ff65171b05...

Powered by Google App Engine
This is Rietveld 408576698