Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2810733004: Adds label_type: Group to gn_isolate_map.pyl (Closed)

Created:
3 years, 8 months ago by sky
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds label_type: Group to gn_isolate_map.pyl Hopefully this gets generating build files on mojo fyi bot working. BUG=705715 TEST=this is test change R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2810733004 Cr-Commit-Position: refs/heads/master@{#463432} Committed: https://chromium.googlesource.com/chromium/src/+/b03d40ddb1f2055726b64457ea5a41d29fb6223f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 8 months ago (2017-04-10 21:15:44 UTC) #1
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-10 21:25:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810733004/1
3 years, 8 months ago (2017-04-10 21:30:36 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:54:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b03d40ddb1f2055726b64457ea5a...

Powered by Google App Engine
This is Rietveld 408576698