Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2810723003: win: Remove tool_wrapper.py cl-compile, it is unused. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, Tomasz Moniuszko
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Remove tool_wrapper.py cl-compile, it is unused. No intended behavior change. BUG=none Review-Url: https://codereview.chromium.org/2810723003 Cr-Commit-Position: refs/heads/master@{#463327} Committed: https://chromium.googlesource.com/chromium/src/+/dfd67dbe4d4cd2a2ad36a5382cc72f01f8260fa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M build/toolchain/win/tool_wrapper.py View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nico
I think this existed in gyp for gyp's msvs-ninja generator (and was copied from there), ...
3 years, 8 months ago (2017-04-10 14:50:54 UTC) #4
scottmg
lgtm
3 years, 8 months ago (2017-04-10 17:54:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810723003/1
3 years, 8 months ago (2017-04-10 18:05:35 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 18:13:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dfd67dbe4d4cd2a2ad36a5382cc7...

Powered by Google App Engine
This is Rietveld 408576698