Refactor VideoCaptureManager::GetDeviceFormatsInUse()

Refactor VideoCaptureManager::GetDeviceFormatsInUse()

VideoCaptureManager::GetDeviceFormatsInUse() [1] has below issues:

1. It unconditionally returns true and modifies a list of things when
it could just return the one thing it provides (when available).
2. Its implementation does not match the specification in its method-
level comment.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/
media/video_capture_manager.h?type=cs&l=156

This CL takes care of these issues.

BUG=702271
Review-Url: https://codereview.chromium.org/2810723002
Cr-Commit-Position: refs/heads/master@{#463659}
Committed: https://chromium.googlesource.com/chromium/src/+/cf466af46f6bc3bd2113e014909f97d1955f12c3

[Chandan, 2017-04-10 13:45:01]

c.padhi@samsung.com changed reviewers:
+ chfremer@chromium.org, emircan@chromium.org, mcasas@chromium.org

[Chandan, 2017-04-10 13:45:01]

PTAL. Thank you.

[chfremer, 2017-04-10 17:24:03]

Overall looking good.
Got 2 questions.

https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_controller.cc (right):

https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_controller.cc:455: frame_rate
= video_capture_format_->frame_rate;
Could it happen that |video_capture_format_| is not yet initialized at this
point?

https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_manager.h (right):

https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_manager.h:155:
base::Optional<media::VideoCaptureFormat> GetDeviceFormat(
Why did you decide to drop the ...InUse suffix from the method name?

[Chandan, 2017-04-11 07:45:06]

c.padhi@samsung.com changed reviewers:
+ a.suchit@chromium.org

[Chandan, 2017-04-11 07:45:07]

Uploaded patch set 2. Please review.

https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_controller.cc (right):

https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_controller.cc:455: frame_rate
= video_capture_format_->frame_rate;
On 2017/04/10 17:24:03, chfremer wrote:
> Could it happen that |video_capture_format_| is not yet initialized at this
> point?

Right, its safe to add a check for video_capture_format_.

https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/video_capture_manager.h (right):

https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/video_capture_manager.h:155:
base::Optional<media::VideoCaptureFormat> GetDeviceFormat(
On 2017/04/10 17:24:03, chfremer wrote:
> Why did you decide to drop the ...InUse suffix from the method name?

Done.

[a.suchit2, 2017-04-11 12:02:36]

The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 12:02:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 12:59:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 12:59:51]

Dry run: This issue passed the CQ dry run.

[chfremer, 2017-04-11 16:17:10]

PatchSet 2 lgtm

[Chandan, 2017-04-11 16:24:18]

The CQ bit was checked by c.padhi@samsung.com

[commit-bot: I haz the power, 2017-04-11 16:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 16:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 16:36:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[emircan, 2017-04-11 16:46:53]

content/browser/renderer_host/media/media_devices_dispatcher_host.cc RS lgtm

[emircan, 2017-04-11 16:52:34]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2017-04-11 16:53:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 17:02:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491929554206310,
"parent_rev": "16e8bdf82977fa9734263248666543e204a930a4", "commit_rev":
"cf466af46f6bc3bd2113e014909f97d1955f12c3"}

[commit-bot: I haz the power, 2017-04-11 17:03:42]

Description was changed from

==========
Refactor VideoCaptureManager::GetDeviceFormatsInUse()

VideoCaptureManager::GetDeviceFormatsInUse() [1] has below issues:

1. It unconditionally returns true and modifies a list of things when
it could just return the one thing it provides (when available).
2. Its implementation does not match the specification in its method-
level comment.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/
media/video_capture_manager.h?type=cs&l=156

This CL takes care of these issues.

BUG=702271
==========

to

==========
Refactor VideoCaptureManager::GetDeviceFormatsInUse()

VideoCaptureManager::GetDeviceFormatsInUse() [1] has below issues:

1. It unconditionally returns true and modifies a list of things when
it could just return the one thing it provides (when available).
2. Its implementation does not match the specification in its method-
level comment.

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/
media/video_capture_manager.h?type=cs&l=156

This CL takes care of these issues.

BUG=702271

Review-Url: https://codereview.chromium.org/2810723002
Cr-Commit-Position: refs/heads/master@{#463659}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf466af46f6bc3bd2113e014909f...
==========

[commit-bot: I haz the power, 2017-04-11 17:03:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf466af46f6bc3bd2113e014909f...