Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2810723002: Refactor VideoCaptureManager::GetDeviceFormatsInUse() (Closed)

Created:
3 years, 8 months ago by Chandan
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor VideoCaptureManager::GetDeviceFormatsInUse() VideoCaptureManager::GetDeviceFormatsInUse() [1] has below issues: 1. It unconditionally returns true and modifies a list of things when it could just return the one thing it provides (when available). 2. Its implementation does not match the specification in its method- level comment. [1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/ media/video_capture_manager.h?type=cs&l=156 This CL takes care of these issues. BUG=702271 Review-Url: https://codereview.chromium.org/2810723002 Cr-Commit-Position: refs/heads/master@{#463659} Committed: https://chromium.googlesource.com/chromium/src/+/cf466af46f6bc3bd2113e014909f97d1955f12c3

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -50 lines) Patch
M content/browser/renderer_host/media/media_devices_dispatcher_host.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 1 chunk +6 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 1 chunk +11 lines, -12 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 1 chunk +13 lines, -20 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Chandan
PTAL. Thank you.
3 years, 8 months ago (2017-04-10 13:45:01 UTC) #2
chfremer
Overall looking good. Got 2 questions. https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_host/media/video_capture_controller.cc File content/browser/renderer_host/media/video_capture_controller.cc (right): https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_host/media/video_capture_controller.cc#newcode455 content/browser/renderer_host/media/video_capture_controller.cc:455: frame_rate = video_capture_format_->frame_rate; ...
3 years, 8 months ago (2017-04-10 17:24:03 UTC) #3
Chandan
Uploaded patch set 2. Please review. https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_host/media/video_capture_controller.cc File content/browser/renderer_host/media/video_capture_controller.cc (right): https://codereview.chromium.org/2810723002/diff/1/content/browser/renderer_host/media/video_capture_controller.cc#newcode455 content/browser/renderer_host/media/video_capture_controller.cc:455: frame_rate = video_capture_format_->frame_rate; ...
3 years, 8 months ago (2017-04-11 07:45:07 UTC) #5
chfremer
PatchSet 2 lgtm
3 years, 8 months ago (2017-04-11 16:17:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810723002/20001
3 years, 8 months ago (2017-04-11 16:24:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/408035)
3 years, 8 months ago (2017-04-11 16:36:11 UTC) #14
emircan
content/browser/renderer_host/media/media_devices_dispatcher_host.cc RS lgtm
3 years, 8 months ago (2017-04-11 16:46:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810723002/20001
3 years, 8 months ago (2017-04-11 16:53:07 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:03:43 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cf466af46f6bc3bd2113e014909f...

Powered by Google App Engine
This is Rietveld 408576698