chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java - Issue 2810713002: 🏡 Disable BottomSheet touches while context menu is open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java

Issue 2810713002: 🏡 Disable BottomSheet touches while context menu is open. (Closed)

Patch Set: Add some comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRecyclerView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java

index 9efdc443d3a31db4bdf23bacae0acd92a308db21..3bfb6510917d5f20dd7a0e9dc4fd2029db0d8c43 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java

@@ -16,6 +16,7 @@ import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.NativePageHost;

import org.chromium.chrome.browser.ntp.ContextMenuManager;

+import org.chromium.chrome.browser.ntp.ContextMenuManager.TouchEnabledDelegate;

import org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;

import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

@@ -60,7 +61,15 @@ public class SuggestionsBottomSheetContent implements BottomSheet.BottomSheetCon

mView = LayoutInflater.from(activity).inflate(

R.layout.suggestions_bottom_sheet_content, null);

mRecyclerView = (SuggestionsRecyclerView) mView.findViewById(R.id.recycler_view);

- mContextMenuManager = new ContextMenuManager(activity, navigationDelegate, mRecyclerView);

+ TouchEnabledDelegate touchEnabledDelegate = new TouchEnabledDelegate() {

+ @Override

+ public void setTouchEnabled(boolean enabled) {

+ activity.getBottomSheet().setTouchEnabled(enabled);

+ }

+ };

+ mContextMenuManager =

+ new ContextMenuManager(activity, navigationDelegate, touchEnabledDelegate);

activity.getWindowAndroid().addContextMenuCloseListener(mContextMenuManager);

mSuggestionsManager.addDestructionObserver(new DestructionObserver() {

@Override