chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 2810713002: 🏡 Disable BottomSheet touches while context menu is open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2810713002: 🏡 Disable BottomSheet touches while context menu is open. (Closed)

Patch Set: Add some comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index e87d966bbe933746ddda3fd145fc771a1d70d551..ead68bca6f70c8dbeca68fa9141f9ed5ce68d92a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -29,6 +29,7 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ChromeFeatureList;

+import org.chromium.chrome.browser.ntp.ContextMenuManager.TouchEnabledDelegate;

import org.chromium.chrome.browser.ntp.LogoBridge.Logo;

import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;

import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener;

@@ -215,8 +216,14 @@ public class NewTabPageView extends FrameLayout implements TileGroup.Observer {

}

});

- mContextMenuManager =

- new ContextMenuManager(mActivity, mManager.getNavigationDelegate(), mRecyclerView);

+ TouchEnabledDelegate touchEnabledDelegate = new TouchEnabledDelegate() {

+ @Override

+ public void setTouchEnabled(boolean enabled) {

+ mRecyclerView.setTouchEnabled(enabled);

+ }

+ };

+ mContextMenuManager = new ContextMenuManager(

+ mActivity, mManager.getNavigationDelegate(), touchEnabledDelegate);

mActivity.getWindowAndroid().addContextMenuCloseListener(mContextMenuManager);

manager.addDestructionObserver(new DestructionObserver() {

@Override