Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2810703005: Fix policy_util iterator and re-enable networking tests (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
brettw, Mike West
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix policy_util iterator and re-enable networking tests This fixes a DCHECK that exposed a poor assumption in RemoveFakeCredentials about DictionaryValue iteration. It was exposed with this CL: https://codereview.chromium.org/2807953002 It also re-enables tests the disabled tests. BUG=710241 Review-Url: https://codereview.chromium.org/2810703005 Cr-Commit-Position: refs/heads/master@{#463783} Committed: https://chromium.googlesource.com/chromium/src/+/6e4bc12318fac3839ddf6f0b69dcbd5bfd962b56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M chromeos/network/policy_util.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
stevenjb
3 years, 8 months ago (2017-04-11 16:49:28 UTC) #3
brettw
lgtm
3 years, 8 months ago (2017-04-11 19:57:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810703005/1
3 years, 8 months ago (2017-04-11 20:45:52 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 21:46:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e4bc12318fac3839ddf6f0b69dc...

Powered by Google App Engine
This is Rietveld 408576698