Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2810633004: Refactor target_sysroot_dir gn argument (Closed)

Created:
3 years, 8 months ago by Sam Clegg
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor target_sysroot_dir gn argument This change was motivated by the need to remove the references to wheezy. I noticed that the target_sysroot_dir argument could be generalized which avoids the extra conditional in sysroot.gni. BUG=697494 Review-Url: https://codereview.chromium.org/2810633004 Cr-Commit-Position: refs/heads/master@{#463368} Committed: https://chromium.googlesource.com/chromium/src/+/75cc3b096e245801afa0607dc4f8adc03566ae16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M build/config/sysroot.gni View 2 chunks +10 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Sam Clegg
3 years, 8 months ago (2017-04-10 18:30:31 UTC) #5
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-10 18:36:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810633004/1
3 years, 8 months ago (2017-04-10 19:35:39 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:45:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75cc3b096e245801afa0607dc4f8...

Powered by Google App Engine
This is Rietveld 408576698