Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2810593003: gpu: Some cleanups. (Closed)

Created:
3 years, 8 months ago by sadrul
Modified:
3 years, 8 months ago
Reviewers:
James Cook, piman
CC:
chromium-reviews, kalyank, jam, sadrul, piman+watch_chromium.org, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Some cleanups. . Use SANDBOXED as the default argument to GpuProcessHost::Get(), since that's the most common use. . Remove unused ash::GPUSupport::GetGpuProcessHandles(). . Remove unused content::GpuDataManager::GetGpuProcessHandles(). . Replace GpuProcessHost::GetProcessHandles() with GetHasGpuProcess(), since the only remaining user (RenderMessageFilter) cares only about the existence of a gpu process, and not about what those processes are. BUG=417532, 709332 Review-Url: https://codereview.chromium.org/2810593003 Cr-Commit-Position: refs/heads/master@{#463324} Committed: https://chromium.googlesource.com/chromium/src/+/ca65d070a3195b1357d3c41edaaba72202470ed7

Patch Set 1 #

Patch Set 2 : tot merge #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -77 lines) Patch
M ash/content/gpu_support_impl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/content/gpu_support_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/gpu_support.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M ash/gpu_support_stub.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/gpu_support_stub.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/gpu_data_manager.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/browser/gpu_service_registry.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
sadrul
piman@ for content/ changes. jamescook@ for ash/ changes. Thanks!
3 years, 8 months ago (2017-04-10 04:18:15 UTC) #8
James Cook
ash lgtm
3 years, 8 months ago (2017-04-10 14:02:46 UTC) #11
piman
lgtm
3 years, 8 months ago (2017-04-10 17:48:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810593003/30001
3 years, 8 months ago (2017-04-10 17:54:36 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 18:09:11 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/ca65d070a3195b1357d3c41edaab...

Powered by Google App Engine
This is Rietveld 408576698