Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/ui/webui/uber/uber_ui.cc

Issue 2810583006: PlzNavigate: Avoid creating WebUI for subframes. (Closed)
Patch Set: @creis suggestions (+rebase) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/uber/uber_ui.cc
diff --git a/chrome/browser/ui/webui/uber/uber_ui.cc b/chrome/browser/ui/webui/uber/uber_ui.cc
index 5cc1e167a9972312c5f32c26098b995b5d2ae43b..dcaf61274d406f1fdadda39e3d713836a0cb2f92 100644
--- a/chrome/browser/ui/webui/uber/uber_ui.cc
+++ b/chrome/browser/ui/webui/uber/uber_ui.cc
@@ -160,13 +160,7 @@ void SubframeLogger::DidFinishNavigation(
}
UberUI::UberUI(content::WebUI* web_ui) : WebUIController(web_ui) {
- if (!content::IsBrowserSideNavigationEnabled()) {
- // This isn't needed with PlzNavigate because when
- // CreateWebUIControllerForURL is called there's always a RenderFrame
- // and the logging happens there.
- subframe_logger_ =
- base::MakeUnique<SubframeLogger>(web_ui->GetWebContents());
- }
+ subframe_logger_ = base::MakeUnique<SubframeLogger>(web_ui->GetWebContents());
content::WebUIDataSource::Add(web_ui->GetWebContents()->GetBrowserContext(),
CreateUberHTMLSource());
« no previous file with comments | « chrome/browser/ui/webui/log_web_ui_url_browsertest.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698