Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: chrome/browser/ui/webui/log_web_ui_url_browsertest.cc

Issue 2810583006: PlzNavigate: Avoid creating WebUI for subframes. (Closed)
Patch Set: @creis suggestions (+rebase) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
diff --git a/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc b/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
index 834082397cb4fc0d38041d1a31b57c73aa4b6f5c..68680698304072ff24778ae290ee40ecbaa71c3b 100644
--- a/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
+++ b/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
@@ -124,6 +124,35 @@ IN_PROC_BROWSER_TEST_F(LogWebUIUrlTest, TestUberPage) {
Bucket(uber_frame_url_hash, 2),
Bucket(uber_url_hash, 2)));
}
+
+IN_PROC_BROWSER_TEST_F(LogWebUIUrlTest, TestExtensionsPage) {
+ content::WebContents* tab =
+ browser()->tab_strip_model()->GetActiveWebContents();
+
+ base::string16 extension_title =
+ l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE);
+
+ {
+ content::TitleWatcher title_watcher(tab, extension_title);
+ ui_test_utils::NavigateToURL(browser(),
+ GURL(chrome::kChromeUIExtensionsURL));
+ ASSERT_EQ(extension_title, title_watcher.WaitAndGetTitle());
+ }
+
+ std::string scheme(content::kChromeUIScheme);
+ GURL uber_url(scheme + "://" + chrome::kChromeUIUberHost);
+ uint32_t uber_url_hash = base::Hash(uber_url.spec());
+
+ GURL uber_frame_url(chrome::kChromeUIUberFrameURL);
+ uint32_t uber_frame_url_hash = base::Hash(uber_frame_url.spec());
+
+ GURL extensions_frame_url(chrome::kChromeUIExtensionsFrameURL);
+ uint32_t extensions_frame_url_hash = base::Hash(extensions_frame_url.spec());
+
+ EXPECT_THAT(GetSamples(), ElementsAre(Bucket(extensions_frame_url_hash, 1),
+ Bucket(uber_frame_url_hash, 1),
+ Bucket(uber_url_hash, 1)));
+}
#endif
} // namespace webui
« no previous file with comments | « no previous file | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698