Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2810583002: SELECT popup: Make OPTIONs taller for touchscreen. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
keishi, kinuko
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT popup: Make OPTIONs taller for touchscreen. On Windows and Linux: If a touchscreen is connected, OPTIONs in SELECT popups have 8px paddings and at least 24px height in order to make it touch-friendly. On CrOS: Apply the taller OPTIONs regardless of existence of touchscreen. On macOS and Android: This CL has no effect. BUG=703971 Review-Url: https://codereview.chromium.org/2810583002 Cr-Commit-Position: refs/heads/master@{#463194} Committed: https://chromium.googlesource.com/chromium/src/+/112094796a99ff35f551467912814d08935b6055

Patch Set 1 : . #

Messages

Total messages: 19 (13 generated)
tkent
keishi@, would you review this please?
3 years, 8 months ago (2017-04-10 03:03:59 UTC) #8
keishi
lgtm
3 years, 8 months ago (2017-04-10 03:30:01 UTC) #11
tkent
kinuko@, would you approve content/child/runtime_features.cc please?
3 years, 8 months ago (2017-04-10 03:32:31 UTC) #13
kinuko
lgtm
3 years, 8 months ago (2017-04-10 08:16:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810583002/20001
3 years, 8 months ago (2017-04-10 08:18:01 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 08:24:52 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/112094796a99ff35f55146791281...

Powered by Google App Engine
This is Rietveld 408576698