Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 2810573002: Use TintedImageButton with @color/dark_mode_tint instead of ImageButton. (Closed)

Created:
3 years, 8 months ago by Leo
Modified:
3 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TintedImageButton with @color/dark_mode_tint instead of ImageButton. Set selected text in tab blue. Screenshot: https://screenshot.googleplex.com/bcPOLLMNKtb BUG=703887 Review-Url: https://codereview.chromium.org/2810573002 Cr-Commit-Position: refs/heads/master@{#463538} Committed: https://chromium.googlesource.com/chromium/src/+/722783997be0338cf14613eca3e58e34a43ef24d

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/java/res/layout/infobar_translate_compact_content.xml View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Leo
Small UI changes for new translate infobar.
3 years, 8 months ago (2017-04-10 01:30:07 UTC) #3
gone
lgtm
3 years, 8 months ago (2017-04-10 17:16:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810573002/20001
3 years, 8 months ago (2017-04-11 04:56:38 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 05:11:59 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/722783997be0338cf14613eca3e5...

Powered by Google App Engine
This is Rietveld 408576698