Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2810533002: rewrite_to_chrome_style: Force Get prefixes on a few more things (Closed)

Created:
3 years, 8 months ago by dcheng
Modified:
3 years, 8 months ago
Reviewers:
Łukasz Anforowicz
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

rewrite_to_chrome_style: Force Get prefixes on a few more things These appear to be problems on Android and OS X. There are probably more... BUG=578344 TBR=lukasza@chromium.org Review-Url: https://codereview.chromium.org/2810533002 . Cr-Commit-Position: refs/heads/master@{#463138} Committed: https://chromium.googlesource.com/chromium/src/+/5e27d4b8d16d9830e52a44a44b4ff501a2a2e667

Patch Set 1 #

Patch Set 2 : Meh #

Patch Set 3 : And windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M tools/blink_rename_merge_helper/COMPONENTS View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 5 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
dcheng
TBRing
3 years, 8 months ago (2017-04-09 10:40:00 UTC) #3
dcheng
Committed patchset #3 (id:40001) manually as 5e27d4b8d16d9830e52a44a44b4ff501a2a2e667 (tree was closed).
3 years, 8 months ago (2017-04-09 10:40:40 UTC) #5
Łukasz Anforowicz
3 years, 8 months ago (2017-04-09 15:14:34 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698