Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp

Issue 2810513002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/filesystem (Closed)
Patch Set: split Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp
diff --git a/third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp b/third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp
index 6cfa612c312c9abb2d024c6b5f1f053bc62ec916..5c7ce69dff69b4849d4520be94131f85ded4bc15 100644
--- a/third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp
+++ b/third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp
@@ -66,8 +66,8 @@ String DOMFilePath::GetDirectory(const String& path) {
}
bool DOMFilePath::IsParentOf(const String& parent, const String& may_be_child) {
- ASSERT(DOMFilePath::IsAbsolute(parent));
- ASSERT(DOMFilePath::IsAbsolute(may_be_child));
+ DCHECK(DOMFilePath::IsAbsolute(parent));
+ DCHECK(DOMFilePath::IsAbsolute(may_be_child));
if (parent == DOMFilePath::kRoot && may_be_child != DOMFilePath::kRoot)
return true;
if (parent.length() >= may_be_child.length() ||
@@ -79,7 +79,7 @@ bool DOMFilePath::IsParentOf(const String& parent, const String& may_be_child) {
}
String DOMFilePath::RemoveExtraParentReferences(const String& path) {
- ASSERT(DOMFilePath::IsAbsolute(path));
+ DCHECK(DOMFilePath::IsAbsolute(path));
Vector<String> components;
Vector<String> canonicalized;
path.Split(DOMFilePath::kSeparator, components);
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698