|
|
Created:
3 years, 8 months ago by emilio Modified:
3 years, 8 months ago Reviewers:
Manuel Rego CC:
chromium-reviews, blink-reviews, qyearsley Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[css-display] Re-enable display: contents pseudo-elements test.
This was fixed recently. It's marked as an expected failure but it really
passes. Shrug.
BUG=657748
Review-Url: https://codereview.chromium.org/2810473002
Cr-Commit-Position: refs/heads/master@{#463178}
Committed: https://chromium.googlesource.com/chromium/src/+/bf38f00db777c0a30e1c5c762e45079ca5b1d4b1
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by ecobos@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ecobos@igalia.com changed reviewers: + rego@igalia.com
Hey Rego, could you stamp this? This test for some reason was passing, but wasn't turning the build red? CC qyearsley for that, is this expected?
On 2017/04/08 10:58:23, emilio wrote: > Hey Rego, could you stamp this? This test for some reason was passing, but > wasn't turning the build red? For some reason == I fixed it on https://chromium.googlesource.com/chromium/src.git/+/1be2a6c872255b63b319d272..., while the tests were disabled. > CC qyearsley for that, is this expected?
On 2017/04/08 10:59:11, emilio wrote: > On 2017/04/08 10:58:23, emilio wrote: > > Hey Rego, could you stamp this? This test for some reason was passing, but > > wasn't turning the build red? > > For some reason == I fixed it on > https://chromium.googlesource.com/chromium/src.git/+/1be2a6c872255b63b319d272..., > while the tests were disabled. If you have an unexpected Pass the bots are still green. So when the tests were re-enabled this was still marked as Failure.
The CQ bit was checked by rego@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by rego@igalia.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1491798792589570, "parent_rev": "ab81cf5d84d85f10c48b1c02dc9e8999df8928a3", "commit_rev": "bf38f00db777c0a30e1c5c762e45079ca5b1d4b1"}
Message was sent while issue was closed.
Description was changed from ========== [css-display] Re-enable display: contents pseudo-elements test. This was fixed recently. It's marked as an expected failure but it really passes. Shrug. BUG=657748 ========== to ========== [css-display] Re-enable display: contents pseudo-elements test. This was fixed recently. It's marked as an expected failure but it really passes. Shrug. BUG=657748 Review-Url: https://codereview.chromium.org/2810473002 Cr-Commit-Position: refs/heads/master@{#463178} Committed: https://chromium.googlesource.com/chromium/src/+/bf38f00db777c0a30e1c5c762e45... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bf38f00db777c0a30e1c5c762e45... |