Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2242)

Issue 2810473002: [css-display] Re-enable display: contents pseudo-elements test. (Closed)

Created:
3 years, 8 months ago by emilio
Modified:
3 years, 8 months ago
Reviewers:
Manuel Rego
CC:
chromium-reviews, blink-reviews, qyearsley
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-display] Re-enable display: contents pseudo-elements test. This was fixed recently. It's marked as an expected failure but it really passes. Shrug. BUG=657748 Review-Url: https://codereview.chromium.org/2810473002 Cr-Commit-Position: refs/heads/master@{#463178} Committed: https://chromium.googlesource.com/chromium/src/+/bf38f00db777c0a30e1c5c762e45079ca5b1d4b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
emilio
Hey Rego, could you stamp this? This test for some reason was passing, but wasn't ...
3 years, 8 months ago (2017-04-08 10:58:23 UTC) #6
emilio
On 2017/04/08 10:58:23, emilio wrote: > Hey Rego, could you stamp this? This test for ...
3 years, 8 months ago (2017-04-08 10:59:11 UTC) #7
Manuel Rego
On 2017/04/08 10:59:11, emilio wrote: > On 2017/04/08 10:58:23, emilio wrote: > > Hey Rego, ...
3 years, 8 months ago (2017-04-10 04:32:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810473002/1
3 years, 8 months ago (2017-04-10 04:33:02 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-10 04:33:04 UTC) #12
Manuel Rego
lgtm
3 years, 8 months ago (2017-04-10 04:33:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810473002/1
3 years, 8 months ago (2017-04-10 04:33:23 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 06:18:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf38f00db777c0a30e1c5c762e45...

Powered by Google App Engine
This is Rietveld 408576698