Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2810443002: MD Settings: People: Fix issues with user icons (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
tommycli
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: People: Fix issues with user icons BUG=709222, 709897 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2810443002 Cr-Commit-Position: refs/heads/master@{#463475} Committed: https://chromium.googlesource.com/chromium/src/+/16b85815d000df5c9bb4603a4085c4906776b9a6

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M chrome/browser/resources/settings/people_page/user_list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.js View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/profile_info_handler.cc View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
stevenjb
3 years, 8 months ago (2017-04-10 16:09:53 UTC) #4
tommycli
lgtm thanks!
3 years, 8 months ago (2017-04-10 22:12:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810443002/20001
3 years, 8 months ago (2017-04-10 23:36:04 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 00:53:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16b85815d000df5c9bb4603a4085...

Powered by Google App Engine
This is Rietveld 408576698