Add unit test and showcase support for search widget.

Add unit test and showcase support for search widget.

BUG=622743
Review-Url: https://codereview.chromium.org/2810403003
Cr-Commit-Position: refs/heads/master@{#465645}
Committed: https://chromium.googlesource.com/chromium/src/+/2ebf1195119e25693bd8e907b9134c072a390f31

[lody, 2017-04-13 13:59:25]

lod@chromium.org changed reviewers:
+ lpromero@chromium.org

[lody, 2017-04-13 13:59:26]

As promised, tests!

[lpromero, 2017-04-13 17:26:09]

Thank you!

lgtm

https://codereview.chromium.org/2810403003/diff/1/ios/chrome/search_widget_ex...
File ios/chrome/search_widget_extension/BUILD.gn (right):

https://codereview.chromium.org/2810403003/diff/1/ios/chrome/search_widget_ex...
ios/chrome/search_widget_extension/BUILD.gn:60: "search_widget_view.h",
You also need to move to this source_set the deps needed for these files.

[lody, 2017-04-14 09:21:10]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 09:21:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 09:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 09:23:27]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lody, 2017-04-14 09:29:24]

Patchset #2 (id:20001) has been deleted

[lody, 2017-04-14 09:41:38]

Patchset #2 (id:40001) has been deleted

[lody, 2017-04-14 11:55:47]

Patchset #2 (id:60001) has been deleted

[lody, 2017-04-14 13:56:10]

Made the change but as my dependencies seem to be a terrible mess I can't make
sure it works until I land the cl it depends on (
https://codereview.chromium.org/2814783003/ )

https://codereview.chromium.org/2810403003/diff/1/ios/chrome/search_widget_ex...
File ios/chrome/search_widget_extension/BUILD.gn (right):

https://codereview.chromium.org/2810403003/diff/1/ios/chrome/search_widget_ex...
ios/chrome/search_widget_extension/BUILD.gn:60: "search_widget_view.h",
On 2017/04/13 17:26:08, lpromero wrote:
> You also need to move to this source_set the deps needed for these files.

Done.

[lpromero, 2017-04-14 15:01:55]

lgtm

[lody, 2017-04-19 15:45:55]

Patchset #3 (id:100001) has been deleted

[lody, 2017-04-19 15:47:00]

Patchset #3 (id:120001) has been deleted

[lody, 2017-04-19 15:51:19]

lod@chromium.org changed reviewers:
+ sdefresne@chromium.org

[lody, 2017-04-19 15:51:20]

Hey sdefresne, can you review for ownership of ios/chrome/test/BUILD.gn ?
Thanks.

[sdefresne, 2017-04-19 15:54:57]

lgtm

https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widg...
File ios/chrome/search_widget_extension/BUILD.gn (right):

https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widg...
ios/chrome/search_widget_extension/BUILD.gn:33: configs += [
"//build/config/compiler:enable_arc" ]
There are no "sources" in that target, so you can remove this line.

https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widg...
File
ios/chrome/search_widget_extension/search_widget_view_controller_unittest.mm
(right):

https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widg...
ios/chrome/search_widget_extension/search_widget_view_controller_unittest.mm:15:
class SearchWidgetViewControllerTest : public PlatformTest {
nit: you can use a typedef (or better the new using syntax) here to avoid
boilerplate

  using SearchWidgetViewControllerTest = PlatformTest;

[lody, 2017-04-19 16:01:53]

https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widg...
File ios/chrome/search_widget_extension/BUILD.gn (right):

https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widg...
ios/chrome/search_widget_extension/BUILD.gn:33: configs += [
"//build/config/compiler:enable_arc" ]
On 2017/04/19 15:54:56, sdefresne wrote:
> There are no "sources" in that target, so you can remove this line.

Done.

https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widg...
File
ios/chrome/search_widget_extension/search_widget_view_controller_unittest.mm
(right):

https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widg...
ios/chrome/search_widget_extension/search_widget_view_controller_unittest.mm:15:
class SearchWidgetViewControllerTest : public PlatformTest {
On 2017/04/19 15:54:57, sdefresne wrote:
> nit: you can use a typedef (or better the new using syntax) here to avoid
> boilerplate
> 
>   using SearchWidgetViewControllerTest = PlatformTest;

Done.

[lody, 2017-04-19 16:01:56]

The CQ bit was checked by lod@chromium.org

[lody, 2017-04-19 16:01:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2810403003/#ps160001
(title: "nits")

[commit-bot: I haz the power, 2017-04-19 16:02:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:10:23]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1492617716237320,
"parent_rev": "17e49b087759887c2ebe54950ab5efdf45472fee", "commit_rev":
"2ebf1195119e25693bd8e907b9134c072a390f31"}

[commit-bot: I haz the power, 2017-04-19 17:10:33]

Description was changed from

==========
Add unit test and showcase support for search widget.

BUG=622743
==========

to

==========
Add unit test and showcase support for search widget.

BUG=622743

Review-Url: https://codereview.chromium.org/2810403003
Cr-Commit-Position: refs/heads/master@{#465645}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ebf1195119e25693bd8e907b913...
==========

[commit-bot: I haz the power, 2017-04-19 17:10:34]

Committed patchset #4 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/2ebf1195119e25693bd8e907b913...