Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2810403003: Add unit test and showcase support for search widget. (Closed)

Created:
3 years, 8 months ago by lody
Modified:
3 years, 8 months ago
Reviewers:
sdefresne, lpromero
CC:
chromium-reviews, extensions-reviews_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, lpromero+watch_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org, ios-reviews+showcase_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unit test and showcase support for search widget. BUG=622743 Review-Url: https://codereview.chromium.org/2810403003 Cr-Commit-Position: refs/heads/master@{#465645} Committed: https://chromium.googlesource.com/chromium/src/+/2ebf1195119e25693bd8e907b9134c072a390f31

Patch Set 1 #

Total comments: 2

Patch Set 2 : deps and libs #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -18 lines) Patch
M ios/chrome/search_widget_extension/BUILD.gn View 1 2 3 3 chunks +26 lines, -18 lines 0 comments Download
A ios/chrome/search_widget_extension/search_widget_view_controller_unittest.mm View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M ios/chrome/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/showcase/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/showcase/core/showcase_model.mm View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
lody
As promised, tests!
3 years, 8 months ago (2017-04-13 13:59:26 UTC) #2
lpromero
Thank you! lgtm https://codereview.chromium.org/2810403003/diff/1/ios/chrome/search_widget_extension/BUILD.gn File ios/chrome/search_widget_extension/BUILD.gn (right): https://codereview.chromium.org/2810403003/diff/1/ios/chrome/search_widget_extension/BUILD.gn#newcode60 ios/chrome/search_widget_extension/BUILD.gn:60: "search_widget_view.h", You also need to move ...
3 years, 8 months ago (2017-04-13 17:26:09 UTC) #3
lody
Made the change but as my dependencies seem to be a terrible mess I can't ...
3 years, 8 months ago (2017-04-14 13:56:10 UTC) #11
lpromero
lgtm
3 years, 8 months ago (2017-04-14 15:01:55 UTC) #12
lody
Hey sdefresne, can you review for ownership of ios/chrome/test/BUILD.gn ? Thanks.
3 years, 8 months ago (2017-04-19 15:51:20 UTC) #16
sdefresne
lgtm https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widget_extension/BUILD.gn File ios/chrome/search_widget_extension/BUILD.gn (right): https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widget_extension/BUILD.gn#newcode33 ios/chrome/search_widget_extension/BUILD.gn:33: configs += [ "//build/config/compiler:enable_arc" ] There are no ...
3 years, 8 months ago (2017-04-19 15:54:57 UTC) #17
lody
https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widget_extension/BUILD.gn File ios/chrome/search_widget_extension/BUILD.gn (right): https://codereview.chromium.org/2810403003/diff/140001/ios/chrome/search_widget_extension/BUILD.gn#newcode33 ios/chrome/search_widget_extension/BUILD.gn:33: configs += [ "//build/config/compiler:enable_arc" ] On 2017/04/19 15:54:56, sdefresne ...
3 years, 8 months ago (2017-04-19 16:01:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810403003/160001
3 years, 8 months ago (2017-04-19 16:02:14 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 17:10:34 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/2ebf1195119e25693bd8e907b913...

Powered by Google App Engine
This is Rietveld 408576698