Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2810383003: Add a categorized document index to docs/README.md. (Closed)

Created:
3 years, 8 months ago by Carlson
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a categorized document index to docs/README.md. BUG= Review-Url: https://codereview.chromium.org/2810383003 Cr-Commit-Position: refs/heads/master@{#464626} Committed: https://chromium.googlesource.com/chromium/src/+/90a1c8c75a3cc1cc60f4bd9cc88473ae161ff038 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Fix some line wrapping, revert some changes that aren't really related to this work. #

Patch Set 3 : Fix more whitespace issues. #

Total comments: 2

Patch Set 4 : Fix typo, a couple of links #

Patch Set 5 : Port threading design doc to in-tree documentation. #

Patch Set 6 : Address a some xdai1@ comments #

Patch Set 7 : Address xdai comments, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -17 lines) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 2 3 4 5 6 5 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 1 2 3 4 5 6 5 chunks +47 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc View 1 2 3 4 5 6 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Carlson
Taxonomy is hard, happy to take suggestions for categorization changes among other things; this is ...
3 years, 8 months ago (2017-04-13 20:23:58 UTC) #3
Dirk Pranke
lgtm, looks like a good start :). https://codereview.chromium.org/2810383003/diff/40001/docs/README.md File docs/README.md (right): https://codereview.chromium.org/2810383003/diff/40001/docs/README.md#newcode234 docs/README.md:234: * [Opening ...
3 years, 8 months ago (2017-04-13 23:53:22 UTC) #4
Carlson
Also checked all the links and fixed a couple that I'd broken by accident. https://codereview.chromium.org/2810383003/diff/40001/docs/README.md ...
3 years, 8 months ago (2017-04-14 00:18:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810383003/60001
3 years, 8 months ago (2017-04-14 00:19:12 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 00:35:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/90a1c8c75a3cc1cc60f4bd9cc884...

Powered by Google App Engine
This is Rietveld 408576698